New version makes compatibility impossible
JaisDK opened this issue ยท 6 comments
Hi,
I have a mod that has compatibility with Chalk, but the structure in the new version makes it impossible to reimplement. Could you change the Mark record to be a normal class with an interface so I can make my own Mark type? I think this is all it would take to get it working again.
Also if you could change this https://github.com/mortuusars/Chalk/blob/1.19-symbolysm/src/main/java/io/github/mortuusars/chalk/items/ChalkBox.java#L94 to use instanceof ChalkBoxItem
instead of .is
Can you clarify about Mark class? Wouldn't you run into problems with the MarkSymbol enum?
I'm trying to make a PR to better explain it and where there's actually a problem is with Mark.fromBuffer
I need sleep but will look at it again tomorrow.
That was a lot more changes needed than I expected. The main part is removing Mark and DyeColor parts from the server/client network packages and making it possible to extend the Mark class to allow for different colors and marks to be used.
You can check out my compat code if you want
https://github.com/JDKDigital/dyenamicsandfriends/blob/dev-1.19.2/src/main/java/cy/jdkdigital/dyenamicsandfriends/compat/ChalkCompat.java