Chance Cubes

Chance Cubes

50M Downloads

Reward schematics always loaded in memory.

Unnoen opened this issue ยท 2 comments

commented

Minecraft Version:

1.12.2

Forge Version:

Forge 14.23.5.2847

ChanceCubes Version:

1.12.2-4.1.0.300

The Issue:

ChanceCubes' SchematicRewardType is always loaded in memory. This results in massive memory usage.

The Woodland_Mansion and Village rewards consume 197.07MB of retained heap. (That's AFTER a GC pass.)

To put this in perspective, that's 60%(!) of vanilla's retained heap. (323.2MB)

All you need to do is a heapdump to find this.

MemoryAnalyzer_2019-11-30_08-16-17

Origin:

https://www.curseforge.com/minecraft/mc-mods/chance-cubes/files/2764219

Logs:

https://gist.github.com/Unnoen/e68ae1d49d42af080cb121e7da25fd30

commented

Yeah, definitely not ideal. I'll work on making then load on run time, errrr reward time? Either way, it needs fixed.

commented

Should be fixed in the latest beta build now available. Reopen if it does not seem to be fixed.