Minecraft Version:

1.12.2

Forge Version:

2847

ChanceCubes Version:

ChanceCubes-1.12.2-5.0.2.345.jar

Reward(s) Affected:

All rewards in the custom rewards folder

The Issue:

When breaking chance cubes, only 2 rewards ever drop no matter how many are in the reward folder. Tested with both 3 and 4 rewards, user also reported only 2 out of a few dozen rewards showing up.
Note, I did disable the default rewards so I don't know if that has something to do with it

Origin:

Curseforge

Logs:

https://pastebin.com/fYWTaw0N

rewards.zip
here's the rewards zip from when I was testing, they're all mostly identical except for some numbers, and if I delete reward 2 and 3, rewards 1 and 4 start dropping again.

The moment I add back 2 and 3, 1 and 4 no longer drop.

Just tested it myself and I did get all 4 to drop, but I saw a very big bias towards the second one. Open like 30-40 cubes and let me know the numbers of each that you get for each

Results of breaking 255 chance cubes: 1 item 1, 118 item 2, 132 item 3, and 5 item 4.

Oof yeah, there's definitely some issue with the random selection

[12:33:12] [Thread-12/INFO]: Loading custom rewards file item1.json [12:33:12] [Thread-12/INFO]: Loaded custom rewards file item1.json! Added 1 rewards [12:33:12] [Thread-12/INFO]: Loading custom rewards file item2.json [12:33:12] [Thread-12/INFO]: Loaded custom rewards file item2.json! Added 1 rewards
Seems you have an issue in your rewards json. The mod is only picking up and loading 2 rewards

Ok after some testing, things are working normally. Unfortunately due to the fact that you have 4 rewards all at a chance value of 0, The Cubes with high and low Chance values (-100 to -20 and 20 to 100) all are outside the range where your 0 chance value rewards are pickable. Thus the cubes pick the "nearest" reward which is just the same 2 rewards over and over. There is a solution. In the Chance Cubes config, change chanceRangeMax and chanceRangeMin to both be 100. this should alleviate this issue