Chance Cubes

Chance Cubes

46M Downloads

[1.15.2] Chance Cubes chest loot enabled causes empty dungeon chests

GatekeeperTDS opened this issue · 19 comments

commented

Minecraft Version:

1.15.2

Forge Version:

31.2.31

ChanceCubes Version:

ChanceCubes-1.15.2-5.0.2.376.jar

The Issue:

Setting ChestLoot = true in the config file causes certain types of loot chests to be empty. I only noticed it with dungeon chests before I set this to false and now loot is generating normally. I did see Chance Cubes correctly generate in village loot chests before I set it to false again, but something's up with the dungeon loot tables.

Origin:

CurseForge.

Logs:

No crash, so no logs.

commented

Hello, I noticed a similar issue a few days ago as well and narrowed it down to this mod.
Here is my latest.log, the error starts at [23:15:20] and seems to be causing a crash in the loot tables.

commented

This happens with ChanceCubes-1.15.2-5.0.2.377 as well. Wasn't able to find any dungeon loot, modded or otherwise, and managed to narrow it down to this mod. Searched the issues tab and now here I am

commented

Confirming this issue still persists with 1.16.2
NullPointerError on LootTable references causing a chain reaction failure. Probably a typo in the item/object reference.

commented

Had this issue as well with MineColonies and Botania installed alongside Chance Cubes on 1.16.4. Changing the value in the config file, made new chests have loot, but the old chests stayed empty.

commented

Can also confirm, latest 1.16.4 build causes chest loot to not be generated properly. Village loot generates fine when used alone, but running Chance Cubes with MineColonies and/or Botania causes the chests that use the same loot table to be completely empty (regardless of whether or not MineColonies/Botania loot would have generated)

commented

It looks like this is happening because of the unnamed loot tables. This happens when Minecolonies or Artifacts is installed, and probably other mods too. Enigmatic Legacy made this easier to identify by printing which mods are causing it.
For reference: Aizistral-Studios/Enigmatic-Legacy#132
Error log

commented

1.16.4, ChanceCubes-1.16.3-5.0.2.394.jar, ton of other mods (no botania or minecolonies tho), but with chance cubes chest loot enabled, chest minecarts spawn empty. full mod list https://pastebin.com/qaQ0jukg

commented

To be more specific after some testing, so far i have seen empty sunken ship, desert pyramid, jungle temple, and nether fortress chests. Chance cubes did spawn properly in village chests.

commented

Confirming it with the 1.16.3 version ChanceCubes 1.16.3-5.0.2.387

commented

For the time being, you are able to turn off the chest generation via the configs

commented

Botania and Chance Cubes.txt
I think it might be conflicting with botania. When I have botania activated it causes the same issues as described above although I have been using the starting chest as a test on a new world generation, I have not tested other chests. When Botania is inactive starting chest and chance cubes seem to generate normally in the chest with the starting loot. When I test chance cubes as the only mod loaded it seems to generate the starting loot and chance cubes normally.

I tried the fix above and it seems like it allows botania and chance cubes to coexsist and still generate starting chest loot normally

.

commented

@dasrukh Can you make a pastebin of that instead of uploading the file?

commented

Also an issue in 1.16.3 FTBTeam/FTB-Unstable-1.16#5

commented

we are having this issue in 1.16.3 and also have Botania

Is Chance Cubes safe to uninstall until this is fixed?

Random question too: Is it possible to re-generate loot in the world/chunk's chests to the players can get some goodies?

Thanks all.

commented

@lulabyte same here, wondering if anyone knows a way to retrogen chest loot so the dungeons on my server aren't pointless XD

commented

I believe this should now be fixed. I'll keep this ticket open for another week, if someone is able to confirm or deny this

commented

Woo!

commented

Fixed on 1.16.5!