Charcoal Pit prevents JAOPCA from generating materials
G-Stav opened this issue ยท 2 comments
This has stumped me for a while now why JAOPCA doesn't want to generate stuff like for example rose gold and the other metals that the ore kiln has support for. Now that Tinkers has it's own version of Rose Gold I wanted JAOPCA to generate the dust version but it doesn't when Charcoal Pit is in the pack. Tried a clean install with
Forge 36.1.0, JAOPCA 1.16.5-3.4.0.9, Jei 1.16.5-7.7.0.101, mantle 1.16.6-1.6.103, Tconstruct 1.16.5 3.0.4.171, with the config option to force generate materials dusts as "*" to generate dusts for all materials and it works. However with charcoal pit added doesn't generate "copper, gold or rose gold". I'm THINKING this might have to do with that Charcoal Pit adds the dust tags for bismuth, bismuth_bronze, black_bronze, brass, bronze, copper, electrum, gold, lead, rose_gold, silver, tin, zinc, even though they're empty. A solution to this might be to change the recipes for the recipes like the ore kiln to have a condition in the recipe and not bake in the empty tags. Tinkers Construct and Immersive Engineering have like the following in recipes for materials they don't themselves generate.
"conditions": [
{
"value": {
"tag": "forge:ingots/brass",
"type": "forge:tag_empty"
},
"type": "forge:not"
}
I can confirm that opening the mod jar in 7zip and just deleting the dust tags/ingot/ore tags fixed this issue.
generating empty tags is the way its supposed to be done. using conditions on kiln recipes wouldnt even work because it only needs 1 of the 3. the problem is jaopca for not checking if a tag is empty. well its more on forge for using the inferior vanilla systems. and they broke the method that checks if a tag is empty so it always returns false.