Charm Reforged

Charm Reforged

8M Downloads

Charm's "Music Improvements" feature causes Overworld music to play in the Twilight Forest

NJL5390 opened this issue ยท 0 comments

commented

Versions

  • Charm version - 2.3.2
  • Minecraft version - 1.16.5
  • Twilight Forest Version - 4.0.435
  • Charmonium Version - 2.3.2
  • Forge Version - 36.1.18

Description
Whenever I enter the Twilight Forest with Charm and Charmonium Installed then Overworld music would start playing in the Twilight Forest. Normally Twilight Forest would block any Overworld music from playing as it has it's own music that plays in that dimension, but Charm seems to override this and makes Overworld music play there anyway.

Disabling Charm's music improvements feature does fix this issue but I quite like Charm's music features and Charmonium's additional music and I would like to be able to use these features at the same time without them interfering with Twilight Forest's own music.

Steps To Reproduce

  1. Start up a world with Charm, Charmonium and Twilight Forest installed.
  2. Create a portal to the Twilight Forest and enter it.
  3. Once you are in the Twilight forest, wait a while.
  4. After a little bit you will notice that Overworld music will likely start playing as opposed to Twilight Forest's own music since there is a lot more Overworld music tracks so it's more likely to get chosen to be played over Twilight Forest's own music.

Stacktrace/Screenshots
https://gist.github.com/NJL5390/bab865098845d801f522a93a4b870cfc