Charm Reforged

Charm Reforged

8M Downloads

Non-vanilla inventory crafting table button not working

VallenFrostweaver opened this issue ยท 3 comments

commented

Minecraft 1.16.5
Forge 36.2.2
Charm 2.3.2

I have a pack with multiple crafting table options. They all will generate the crafting button in the inventory when carried. None but the vanilla crafting table will work.

commented

Having a similar issue, however the modded crafting tables for Oh the Biomes You'll Go won't show the portable crafting button at all.

commented

To add to that, just checked the code and while the UI button is checking for the tag, the actual crafting process checks for the vanilla crafting table only:

https://github.com/svenhjol/CharmForge/blob/master/src/main/java/svenhjol/charm/client/PortableCraftingClient.java#L90

https://github.com/svenhjol/CharmForge/blob/master/src/main/java/svenhjol/charm/message/ServerOpenCrafting.java#L28

commented

it's the tags on the crafting tables in the other mods, afaik. The author of Morecraft is planning on adding Charm support in the next update, if this helps.