Crash while loading mods related to mixin
StormCircuit opened this issue · 28 comments
Versions
- Charm version - 2.2.0, 2.2.1, 2.2.2 (all of them crash under similar circumstances)
- Minecraft version - 1.6.5
Description
Minecraft crashes on load with forge 1.16.5 - 36.0.22
Optional: Steps To Reproduce
Using just Quark-r2.4-304, AutoRegLib-1.6-47, and charm-forge-1.16.4-2.2.2 Minecraft crashes while loading mods. No crash report is generated but through examining 'latest.log' the error appears to be related to mixin. Pastebin link below.
When downgrading to charm-forge-1.16.4-2.2.1 the crashes disappear. But with a larger set of mods I crash with all versions of charm for 1.16.4 (2.2.2, 2.2.1, 2.2.0)
Optional: Stacktrace/Screenshots
latest.log log for large set of mods:
https://pastebin.com/RTDCdz8g
screenshot of mods that always crash with Charm:
latest.log for just quark, autoreglib, and charm 2.2.2:
https://pastebin.com/UeeSRSnn
I apologize if the pseudo 2-in-1 bug report or bug reporting with the larger set of mods is unconventional or not proper. Please let me know if I can correct the bug report.
I also got this crash, but only after updating to forge v36.0.22, v36.0.7 did not crash with it.
https://gist.github.com/WenXin20/397719fdcfcdcab0959e40648920f425
I can confirm WenXin20's solution, actually I downgraded to v36.0.21 and it stopped crashing.
*corrected v.35 to v.36 in this comment for future reference
Same issue here using forge v36.0.22. Downgrading to v36.0.21 fixes the crashing issue.
Conflicts with a change made in Forge 36.0.22: https://github.com/MinecraftForge/MinecraftForge/blob/1.16.x/patches/minecraft/net/minecraft/util/Util.java.patch, which makes the logging quieter.
Yep. What Hubry said. As of Forge 36.0.22, the datafixer mixin is no longer needed. Speaking of which, I should remove my datafixer workaround from my mod as well lol
Doesn't look like a fault of Charm, but rather the conflict between Quark and literally every single MCreator mod with worldgen. MCreator generated code's quality is so shoddy...
Anyways, I would recommend putting a
require = 0on this injection so that if anything changes again it doesn't crash - this feature is so inconsequential, crashing from this is many orders of magnitude more annoying than seeing these few lines of warnings.
I’m getting a launch crash but I don’t have any mcreator mods
(To bugman) Can you try sharing the latest.log file? It may have more info. You can get the log file by going into the logs folder above the mods folder and find latest.log inside it
@BugmanBugman is that happening with CharmForge 2.3.2 or 2.2.2? If the latter, please update and try again.
Edit: link to latest version for testing https://github.com/svenhjol/CharmForge/releases/download/2.3.2/charm-forge-1.16.5-2.3.2.jar
CharmForge 2.3.2
I attached the latest.log in my last comment.
Where do I need to set this "require = 0" flag or does this have to be done by mod creators?
@Zothen1973 don't worry, that's something that would be done by a developer in their mod.
Looking at your latest.log, it's crashing out with
[24Feb2021 15:36:23.787] [main/FATAL] [net.minecraft.server.Main/]: Failed to start the minecraft server
java.lang.NullPointerException: null
[...]
at vazkii.quark.base.world.WorldGenHandler.onBiomesLoaded(WorldGenHandler.java:161) ~[quark:r2.4-306]
@Hubry I guess the above is what you were saying about worldgen crashes with MCreator mods?
Yeah. Quark crashes because mcreator makes ConfiguredFeatures that are not registered and sometimes cannot be parsed to json. Mcreator really should fix that as it’s concerning to have broken ConfiguredFeatures lol
Without "Charm", my server + Quark starts without any crash. Even with worldgen mods like BoP and/or Byg,
Other mods like "Repurposed Structures" are causing a crash too, though.
@Zothen1973 Come over to my github then if my mod repurposed structures is crashing. My mod too will crash due to broken configuredfeatures from other mods. I can help you find which feature and mod it is coming from. Basically, remove all crashing mods and then put on the mod Blame. Start the world. And then give me the latest.log for me to read Blame's output
Newest version still crashes on server side 1.16.5 Forge 36.0.42.
Please post your crashlog
I would, but no crashlog is generated, only the standard logs.
Doesn't look like a fault of Charm, but rather the conflict between Quark and literally every single MCreator mod with worldgen. MCreator generated code's quality is so shoddy...
Anyways, I would recommend putting a require = 0 on this injection so that if anything changes again it doesn't crash - this feature is so inconsequential, crashing from this is many orders of magnitude more annoying than seeing these few lines of warnings.
The mixin responsible for the error (UtilMixin) was removed in the latest version of CharmForge (2.3.2). If there's another mixin causing the issue, please let me know which one to sort.
Deleting the config seemed to have to fixed it for me
as in deleting the config for charm and using the latest version of both charm and forge fixed it?
Deleting the old config does fix the crash at startup. No further crashes after playing a while.
forge: 1.16.5 36.0.39
charm 2.3.2
Updating again to say that you need to delete the config every time you start or it will crash over and over.
@svenhjol Since you asked for another mixin crash, there we go
You & BetterEnd mod have rivalry going on in the mixin process