Charset (1.10.x)

Charset (1.10.x)

3M Downloads

Tank crash when being filled from 3rd party source

Lothrazar opened this issue ยท 2 comments

commented

https://pastebin.com/YVtMYsF6

Was reported to me Lothrazar/Cyclic#605

I have checked into my pipe and pump code, it seems ok and it works with many other tanks and fluid related machines.

commented

Actually, that crash log implies you're trying to fill my tank with a null FluidStack. You shouldn't be doing that, but I added a check anyway as it saves some time if someone else tries to do so.

commented

Oh yeah my bad oops. Ill do a null check on my side to. Since Item stacks are never null i must have assumed or gotten lazy.