Charset (1.10.x)

Charset (1.10.x)

3M Downloads

CME when piping into chest from 2 separate TE's

oitsjustjose opened this issue ยท 9 comments

commented

I'm probably begging to get yelled at... but I compiled a build of Charset after your massive commit today, and ran into this crash when piping items out of my two separate tile entities (a cobblegen and smooth stone generator) into the same chest.

commented

That's good. CharsetPipes is not at all tested.

commented

Temporary fix applied; better fix will be written someday.

commented

"better fix will be written someday" a.k.a. there'll never be a different piece of code thereinplace.

commented

Yes!

commented

Yes, that.

commented

It's now 2017 and the temp fix is still in use. :P

There's nothing more permanent than a temporary fix that works.

commented

@unascribed Honestly, #6 is a much worse bug from 2015 that I still haven't properly fixed.

commented

@asiekierka Ehh, that's dropping items on the floor, which people are used to from Buildcraft. This issue is/was a crash.

commented

@unascribed I'm not even sure if the fix is temporary anymore, seeing as that part has been rewritten again and again in 2016... might as well close it.