Chat Heads

Chat Heads

35M Downloads

Crash on Fabric 1.20.1 with Clean Chat + Incompatibility with Origin Realms server

Deemitry88 opened this issue ยท 15 comments

commented

It just crashs whenever I just start the game
https://mclo.gs/BqgRd0k

commented

If you want to know, Origin realms (as you can see) uses another system to send message in chat (not the vanilla one with the "<>") and I think the "Player" tag is interfering with the mod, the weird thing is that I saw the head for a fraction of a second so it should be compatible ๐Ÿค”

commented

Found the problem ! The mod is not compatible with clean chat because it changes the same thing I think

[Render thread/WARN]: @ModifyConstant conflict. Skipping chat_heads.mixins.json:ChatComponentMixin from mod chat_heads->@ModifyConstant::chatheads$moveTagIcon(I)I with priority 990, already redirected by cleanchat.mixins.json:ChatComponentMixin from mod cleanchat->@ModifyConstant::moveIcon(I)I with priority 1000

commented

Ah you found it already, I was just typing! ๐Ÿ˜„

As you said, it's a conflict with CleanChat. We both want to move the tag icon but only one @ModifyConstant can apply.

This looks like a job for MixinExtras, though it probably requires changes on both sides - I'll see if I can fix/PR something tomorrow.

commented

anyway chat heads doesn't work on origin realms (even tho I can see the head for a fraction of a second it disappears) idk if you can do something about this but I would be still good if you fix it if I need it for another thing

commented

Is it only on Origin Realms? If so, that's weird, as it's a vanilla-compatible server I think, so it shouldn't really be different to any other server.

What you are describing definitely sounds like a mod conflict though.
Looking in you modlist, the mod ChatAnimation sounds like it could cause such issues and looking at the code, I think I have some idea of why. Try removing that mod and see if that fixes it.

commented

nah it is still isn't working
image

commented

Looks like I need to check out Origin Realms some time.

commented

Released a new version which fixes the compatibility issue with Clean Chat on our side - it might still require the pull request for both to work without issue though.

Also, I did just join Origin Realms using only Chat Heads for a test and the chat heads seem to work just fine:
test
(I didn't try to chat, but chat from others did have heads.)

It's surely a compatibility issue with one of the 277 other mods, but I can't tell which one.
A few chat related candidates that spring out are chatanimation, cleanchat (well we had that), compact-chat, dcch, emojitype....
I did try it again with those but still couldn't replicate the issue.

It might be easier if you try to systematically find the mod causing the issue:
Half your mods, check if the issue is gone.
If it is: It's one of the mods in the disabled half.
If it isn't: It's one of the mods in the enabled half.
Now use the "broken" half, then repeat the steps, halfing again and again, geting closer and closer to the mod causing the issues.

If the mod list is small enough I can go through and check them.

P.S.
One issue I found was with Compact Chat. When it combines messages, the combined text won't have a head:
issue
Which is odd because I thought I already fixed that issue. Put this into #75.

commented

so the problem was comming from slyde (wich is a mod that aims to do this :
image
on every slider)
and I guess my chat sliders were not like it should be but by removing the mod and putting it again, it reset and I don't have any problem anymore

commented

How weird!
Glad you found the issue, and even better it's not a mod compatibility issue! (Well, besides Compact Chat)

commented

so do you think you could fix the glitch with compact chat ?

commented

I'm debugging as we speak.

And I think I just found the cause, CompactChat changed their mixin priority, easy fix, let's try.

...

It works! Guess another release is due.

commented

There we go!
I've only published a 1.20(.1) version, since Compact Chat isn't yet compatible with newer versions.

commented

P.S.
The Clean Chat PR was just accepted, so I'd expect a new version soon.

commented

Yeah I just saw Clean Chat being updated, thanks very much for all your attention !