Chat Patches

Chat Patches

2M Downloads

Figura compat and `CME` - 8.0-alpha.3+1.21.4-fabric

domolords opened this issue ยท 13 comments

commented

cannot join a server without it booting me out on the last joining message with a Network protocol Eror message right when I'm about to see the game. Only if chat is still (no new chats) can I join, it's very rare I get a moment when no new chat messages are popping up while I'm joining. Soi can't unless I get lucky. Or relaunch the game a few times. Log: https://pastebin.com/y9fEXgKY

Extra Mod info and System Information (copied from an unrelated crash report. However, almost all of this info is still valid) https://pastebin.com/wttwApRF

Figura custom nameplates, Chat heads, and Streammotes could be a point of conflict. I also have narrator: narrates chat on however it only reads chat messages from mods and sys admins. Other things that effect chat are custom chat plugins for the server (which runs on folia), unless I forgot something.

commented

bugs seem like an inaccurate tag because this is most likely something wrong on my end, (i've had a few mods having their configs get corrupted recently and stuff, this week) but it seems to be more of a compatibility issue.

commented

https://mclo.gs/VBd9Pfx

section starting at line 1374 and similar sections of this live log is what pops up the moment the error happens, There are most likely other instances of this too. As well as other errors for other things.

commented

is this #245?

commented

problably

commented

I just realized I had mod menu disabled on accident, (however Catalogue and Menulogue were enabled) This could be Menulogue not having the Mod Menu be available to reference.

commented

I mean, idk if it's the same. Today is a new day and I was able to log into the server, but after a while it booted me out with the network protocol error. If I have chat hidden, it may not happen but then I can't tp to people, buy from shops, and /home and stuff lots of plugins utilize chat.

This just started happening it seems. I've been using just mod menu with this mod, but then I got this error. I saw in a stack trace that this mod is 'missing dependencies' of both Menulogue and Catalogue, so I installed those two and for a week stopped getting the network protocol error issue. But now it happens way more frequently.

Could this be a config file got corrupted? When a specific mod, out of nowhere stops me from launching or joining, Sometimes it's a config file, a broken thing in a cache, or an SQLITE or something that got corrupted. and I have to delete it and allow the mod to generate a new one, or repair the file(s).

commented

nah still happens, and if i can get in the server, I seem to get booted out after a while.

commented

issues may be problems related to modified playernames and duplicate counters. I remember seeing "duplicate" and "modify playername" in some logs

Edit: I turned off Duplicate counter and playername text toggle I will see if that helps

Edit 2: that seems to have helped for now, we will see if it lasts.

commented

Menulogue and Catalogue are just suggested alternatives to modmenu, it doesn't matter which one you use.

i don't recall what this specific log said but most errors happen with message modification or the chat log. but if it's not an IllegalStateException/IndexOutOfBoundsException then it's probably different

commented

check the new alpha and see if it goes away, otherwise ill review tm

commented

the first issue of the above list should be fixed in alpha 3. you will probably still get log warnings, so feel free to send those over and i'll work on those. hopefully the figura component resolves itself, but let me know how alpha.3+ is working.

edit: issue two should also be fixed now, i figured it wasn't that important nor helpful. if the current alpha doesn't work, try one of these bleeding-edge artifacts: https://github.com/mrbuilder1961/ChatPatches/actions/runs/16632586788/artifacts/3652392789

commented

Edit: I turned off Duplicate counter and playername text toggle I will see if that helps

these errors are caused by the dupe counter, so you should only need to disable that; the playername formatter should work just fine.

but i'm going through the log right now and holy shit. there are like 4 different things going on here:

  1. main crash error, IndexOutOfBoundsException: i just fixed this a couple days ago and made a dumb mistake that undoes the entire fix lmfao. consider this done
  2. the same error as above, but as a log warning. this specific case happens when a message somehow evades chat patches' message modification, and is more for me to see so i can prevent it from messing up more stuff down the line. tl;dr: it's just log spam
  3. ConcurrentModificationException: this one seems to be caused by Figura trying to modify a chat message while the chat log is being restored into the chat. not sure if this is a freak stroke of unluck, but if it continues to happen please open an issue over there and reference this comment or issue!
  4. i'm just being dramatic # 3 was the last error

i can fix the crash later today and try to see what's happening with 2 and 3, but they could just be out of my control. sorry for the confusion, hopefully this is helpful!