Chat Patches

Chat Patches

2M Downloads

Compatibility with figura and certain servers - 192.2.1

Aces-and-Jacks opened this issue ยท 21 comments

commented

Description

Whenever I join on certain servers like visit.uncensoredlibrary.com with figura installed it causes an error when chatting

How to reproduce

Install chat patches and figura and go onto visit.uncensoredlibrary.com
Unable to chat

Expected result

I'm able to chat

Log file link

Don't paste the whole log here!! Just copy and paste it into a site like mclo.gs or pastebin.com. Logs are located in the Minecraft directory folder, under /logs and /crash-reports.

Specs and Details

Required information:

  • MacOS
  • 192.2.1
  • Quilt 0.18.3 and 4.0.0-beta.29+0.75.1-1.19.2 API
  • YetAanotherConfigLib 2.2.0-for-1.19.2 and Mod Menu 4.1.2
  • list of all installed mods (can be a list copied from a log file OR a screenshot)

Optional:

  • chatpatches.json file (pasted like: ```json\n<config data>\n```)
  • chatlog.json file (DO NOT PASTE)

Additional context

Kingdom-of-The-Moon/FiguraRewriteRewrite#66 has all the logs and context

commented

the jar under libs? The one that isn't source?

commented

Yup works now. Thought it didn't since there was an error, tho the chat still showed text, but went out and back in, and it worked.

commented

Wasn't sure if you wanted this closed until the fix was released or not so I'll just close

commented

that error only occurs when Chat Patches doesn't modify messages, which should be never even if all of the modules are disabled. could you provide a screenshot or video as well?

commented

A screen shot of chat patches with figura on the server?

commented

yes, a few messages would be great

commented

Screen Shot 2023-03-11 at 3 57 26 PM

this

Screen Shot 2023-03-11 at 3 57 56 PM

this

Screen Shot 2023-03-11 at 3 58 14 PM

commented

Tried typing a . and it didn't send

commented

Screen Shot 2023-03-11 at 4 02 00 PM

this and

Screen Shot 2023-03-11 at 4 02 21 PM

are without figura

commented

Screen Shot 2023-03-11 at 4 06 20 PM

This and

Screen Shot 2023-03-11 at 4 06 33 PM

are with figura but not chat patches

commented

So first one is with both installed, second is chat patches and not figura, third is figura but not chat patches

commented

and what kind of things does figura do to the chat?

commented
commented

I don't really know

commented

in the meantime, you can try disabling the duplicate message counter.
i'll also try and add some sort of error catching so it doesn't prevent chatting if errors occur in the future.

commented

and what kind of things does figura do to the chat?

Figura is a avatar creation mod that provides different ways to interact with client
Figura does several things to the chat box:

  • It provides a way for user to intercept contents of a message that has arrived on client
  • It preprocesses message to replace all occurrences of username with name set by it's avatar as well as to add it's badges (like figura user badge and other special badges)
  • lastly it allows users to use emojis provided with mod in the same style that discord does (i.e. I :heart: you will be changed to I โ™ฅ you if emojis are enabled)
    both badges and custom emojis are made using custom fonts
    that is all (as far as i remember, though for more accurate answer it would probably be best to ask @Francy-chan)
commented

ok thanks for the info, i pushed a few commits that should hopefully fix the issue. @Aces-and-Jacks could you see if the error still occurs using the main jar from https://github.com/mrbuilder1961/ChatPatches/suites/11501286023/artifacts/594346079 ?

commented

so just to be clear, are messages normal again or do they look like vanilla?

commented

Screen Shot 2023-03-12 at 4 26 03 PM

yup, works

commented

Do you plan on back porting this to 1.19.2?

commented

probably at some point but not for at least a couple weeks