ChemLib

ChemLib

14M Downloads

Tag sodium chloride as forge:salt?

F8enjoyer opened this issue ยท 1 comments

commented

Would it be possible to add tag "forge:salt" to sodium chloride?
It would be great to allow some cooking ingredients to be synthesized and used with other mods.

I think the tag might make sense on the compound instead of the dust, to give appropriate ratios.
(For comparison, minecraft sugar seems to have a 1:1 ratio with the sucrose compound, not the sucrose dust)

It could also be nice to add dissolver recipes for the salt items from mods like mekanism and croptopia, but perhaps that is a separate issue.

Implementation ideas?

I'm new to the codebase, but it looks like ItemTagGenerator.java could be a place to do it?
(OTOH, there appears to be a pattern developing, so perhaps adding support for tags in ChemicalRegistry.java and compounds.json is the way to go?)

I imagine there could also be a fabric equivalent, but I haven't looked there yet.

Thanks!

commented

(Obligatory Ex&F video: https://www.youtube.com/watch?v=RJh9yTIBY48 ๐Ÿ˜‰)