Cherished Worlds (Fabric 1.16.1 - 1.19.2)

Cherished Worlds (Fabric 1.16.1 - 1.19.2)

Mods
10M Downloads

[Feature]: Config for disabling the mod on some menus

Closed this issue ยท 2 comments

commented

What is the new feature or improvement?

Have a config file so we can disable the mod on only the menus we want (so it can work with other mods)
For example, I use essential which already have a favorite tab, but cherished worlds breaks the multiplayer menu, I want to disable it only for the multiplayer menu but not the singleplayer one.

commented

Hi, Essential developer here. I'm investigating the incompatibility between Essential and Cherished Worlds. The root cause of the issue is this:

cherishedworlds/common/src/main/java/com/illusivesoulworks/cherishedworlds/client/favorites/FavoriteServers.java

Lines 31 to 39 in 69b02e1

@Override
public void init(JoinMultiplayerScreen screen) {
AccessorJoinMultiplayerScreen accessor = (AccessorJoinMultiplayerScreen) screen;
ServerSelectionList selectionList = accessor.getSelectionList();
if (selectionList != null) {
selectionList.updateOnlineServers(screen.getServers());
}
}

This code is invoked from Fabric's AFTER_INIT screen event, which is after Essential modifies the server list entries. This results in Essential's changes being overwritten, breaking our Friends & Featured tabs.

I'm not sure why this code is needed at all. I removed it and everything seemed to continue to work fine, and Essential's tabs worked as expected. Clicking the star messes things up a little bit, but that's not a huge deal given everything else is functional.

commented

Hmm, you're right. I'm not sure why that code is there either. It's been there since the inception of the feature back in 1.16, so it existed for some reason but that reason alludes me after all these years. And it may very well be outdated by now.

It doesn't seem to break anything in my testing either so I don't have a problem with just removing it.