Version 0.51 and Inventory pets (missing textures)

Question

Version 0.51 and Inventory pets (missing textures)

BrelanAllin opened this issue 8 years ago · 11 comments

BrelanAllin commented 8 years ago

Works fine with version 0.50.

No update to inventory pets in months.

Most items are missing textures.

capnkirok · Answer 1 · 2016-10-14T05:39:27.000Z

Can confirm, 4 separate reports since yesterday. (Hi @Drullkus!)

Drullkus · Answer 2 · 2016-10-14T16:51:42.000Z

Wait... what?

I know we changed our way of loading our resources, are you talking about InvPet's Item icons being missing? Weird...

Drullkus · Answer 3 · 2016-10-14T16:52:49.000Z

~~I'm gonna go ahead and look at how you handle resources in your json files, there might be some weird stuff happening.~~ Your Git Repo is empty! :(

capnkirok · Answer 4 · 2016-10-15T06:52:40.000Z

OK, so you were RIGHT! It was the JSON... I found that one texture was working: The Anvil Pet. So I reviewed the Anvil Pet JSON side by side with the Apple Pet. ~~There was no difference other than the file name (e.g., not smart quotes or a missing character).~~ I then re-saved the file and tested again. Now the Apple Pet worked, with no changes other than re-saving. Seems like Chisel/Forge didn't like something about the file format.

Why Chisel had problems but other mods didn't is quite strange to me. I mean you aren't reading the raw JSON are you? Perhaps it's having trouble interpreting the file format? I'm uploading a JSON file that has 'troubled' formatting in case you want to do some error trapping.
banana_pet.zip

Anyway, thanks for the pointer. I'll get an update today. And... yes, I need to publish my code on git.

capnkirok · Answer 5 · 2016-10-15T07:47:57.000Z

EDIT: If you look at that JSON file you will see there is in an extra closed bracket '}', which is being fixed when I re-save. Mea Culpa! Forge seems to ignore this, but Chisel has an issue.

Curious to know what you are doing with the JSON. I will poke around your repo.

Drullkus · Answer 6 · 2016-10-15T08:01:52.000Z

Glad to hear the problem has been found :) Yes, so we've got a custom json loader in front of our custom asset system, that enables us to put CTM on not only our Chisel's blocks, but blocks from other mods. :) It even works on models! There's a few kinks @tterrag1098 needs to fix is all before I make a real announcement and push resourcepack creators to try it out

capnkirok · Answer 7 · 2016-10-15T08:10:53.000Z

That is very cool. I've only recently discovered the power of JSON to open up new connections with other mods. Awesome idea.

capnkirok · Answer 8 · 2016-10-15T08:14:31.000Z

Friends again:

minecreatr · Answer 9 · 2016-10-15T12:35:53.000Z

Yay Friends :D

On Sat, Oct 15, 2016 at 1:14 AM, Purplicious_Cow [email protected]
wrote:

Friends again:

[image: friends_agai]
https://cloud.githubusercontent.com/assets/9628379/19408548/244879de-92c0-11e6-9aed-9fe2d23fc64f.png

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#257 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFwZ2eFTKkfpXSPYfNg9CEYAaQxSGsikks5q0ItogaJpZM4KWhPP
.

capnkirok · Answer 10 · 2016-10-14T20:42:11.000Z

Could be. Let me know if you find anything. I'll also look tomorrow.

Drullkus · Answer 11 · 2016-10-15T22:28:59.000Z

Issue resolved, we can all be friends now :D

Share to