Chisel Chipped Integration

Chisel Chipped Integration

Mods
1M Downloads

[1.11] Carving.getOreGroup fails when passed ItemStack.EMPTY

AtomicBlom opened this issue ยท 1 comments

commented

Hi there team,

I've got an issue with the Shear Madness port, because a slight oversight in Carving. The line of code causing me issues specifically, is

Chisel/src/main/java/team/chisel/common/carving/Carving.java

Line 175 in eddd8ae

if(stack != null)

Here is the log: https://gist.github.com/AtomicBlom/2b4f70880bbd6428f97e5d1adcd4c884

ItemStacks should not be null in 1.11, and the == null check should be !itemStack.isEmpty()

There are also a few other potential issues with itemStacks in Carving related to null checks. I tried loading up my fork to give a PR, but some dependancies (mcp mappings & forge aren't downloading for me at the moment)

commented

Oredict variants are gone for good, so this is "fixed"