Chisel Chipped Integration

Chisel Chipped Integration

1M Downloads

[1.7.10] Chisel causes crash

Dream-Master opened this issue ยท 1 comments

commented

If i try to use chisel on a block while my inventory is full the game crashes.

crash log:
https://github.com/GTNewHorizons/NewHorizons/files/924591/crash-2017-04-16_23.12.28-client.txt
https://github.com/GTNewHorizons/NewHorizons/files/924592/crash-2017-04-16_23.22.59-client.txt

Tested with the Concret Block.
there were also concrete laying on the ground that i were trying to pick up.

If the inventory have left one slot it not crash.

We using it in a Modpack: https://github.com/GTNewHorizons/NewHorizons/

Seems itemstack1 is not null-checked in Chisel:
https://github.com/Chisel-Team/Chisel/blob/1.7/release/src/main/java/team/chisel/inventory/ContainerChisel.java#L108
And also not in CoFHLib:
https://github.com/CoFH/CoFHLib/blob/1.7.10/src/main/java/cofh/lib/util/helpers/InventoryHelper.java#L315

GTNewHorizons/GT-New-Horizons-Modpack#1301

Using forge 1614
cofhlib 1.2.1.185
Nei 1.0.5.120

commented

Could you test without CoFH mods? They are on the top of the crash stack.