Chisel Chipped Integration

Chisel Chipped Integration

1M Downloads

MC 1.12.1 Extreme Request - Chisel Should fail on load if CTM is not present to warn users like a normal mod!

P3rf3ctXZer0 opened this issue ยท 7 comments

commented

I just wasted 3 fucking hours because your mod still tried launching without CTM! I didn't realize I had forgot CTM and was trying to fix a crash as seen here.

https://gist.github.com/P3rf3ctXZer0/547b66facce908b72d024c49fb0eb12b

please make sure to deny mod initialization in the future if users forget to add CTM.

Glitchfiend/BiomesOPlenty#1097

I am so pissed right now.

commented

But what should Optifine users do? CTM is said to be implemented inside Optifine and will conflict with CTM mod.

commented

I'm not even sure how your game launched without CTM. If you attempt to launch Chisel without CTM, the launch already catches itself with this screen.

screen shot 2017-08-20 at 1 48 13 am

commented

Could be a windows 10 bug I don't have Linux or Mac! At any rate it is strange.

commented

Nope, I can confirm that chisel + biomesoplenty - ctm = weird uninformative crash.

See crash-2017-08-20_23.00.43-client.txt.

Having just noticed #480, I'm guessing this is a case of Chisel not throwing MissingModsException soon enough to prevent BoP falling on its face.

commented

Additional Crash without CTM involving C&B
ChiselsAndBits/Chisels-and-Bits#302

commented

This is a long standing forge bug that I have mentioned to lex, but fell on deaf ears. A mod erroring can cause an exception to be swallowed, and other mods will have their registry events called without preInit having been called, causing strange errors like this. The only way to know the original crash is to remove other mods, which is obviously not practical.

This bit of code can cause these swallowed exceptions to be printed.

commented

@tterrag1098 Lex and his team don't want to deviate from core vanilla code. Trust me I have asked them repeatedly for things that help with modders and moddies. This includes increasing forges ID pools Manage Java a bit more differently Etc. So if he hasn't budged yet he never will.