Chisels & Bits - For Fabric

Chisels & Bits - For Fabric

2M Downloads

Flan claiming incompat

Flemmli97 opened this issue ยท 8 comments

commented

Chisel and bits ignoring claimed areas.
With chisel and bits you can place any blocks inside claimed areas.

Solution is here:
see Flemmli97/Flan#173 (comment)

commented

Giving that flan is not properly cancelling the event, and that they are not responding to my inquiry: I am going to close this ticket as not planned.

commented

i cannot cancel the event completely as i depend on the split of item use and block use of that event.

commented

What do you mean?
You can either just allow the interaction or you do not.

And again, the methods mentioned in the FLAN ticket do not exist, nor does the mentioned class; I checked yarn, mcp and official. What do you expect C&B to do or what does your mod want from C&B here? I listen to somebody right-clicking or left-clicking a block and then act accordingly if he or she holds the relevant item.

This is not rocket science, and many other mods out there do the same. So how do you handle those?
I want to provide compatibility but you will need to meet me half way here.

commented

RightClickBlock is a forge event.

idk what exactly changed with 1.19 but here in 1.18:
https://github.com/ChiselsAndBits/Chisels-and-Bits/blob/version/1.18.2/platforms/forge/src/main/java/mod/chiselsandbits/forge/events/RightClickEventHandler.java

i guess since you simply return DEFAULT here
https://github.com/ChiselsAndBits/Chisels-and-Bits/blob/version/1.18.2/common/src/main/java/mod/chiselsandbits/logic/RightClickInteractionHandler.java#L57

the event handles item use on block and block use. cancelling the event causes neither to be processed yes. but you can also can only disable one of them without cancelling the whole event.

assuming you use similar logic in 1.19 this also applies to 1.19

commented

Wondering if there's a fix or workaround for this as I'm experiencing the same issue in 1.19.2.

commented

Not at the moment.
I am working on a fix. But this should already be fixed in 1.19.2

commented

Hello i wanted to ask if this would be possible to be fixed in 1.18.2? I can see that you were working on a fix and should be fixed in 1.19.2 but i wanted to check for 1.18.2
Sorry if im a pain about this xd

commented

Sadly I won't be able to backport this