Chisels & Bits - For Fabric

Chisels & Bits - For Fabric

2M Downloads

`RightClickEventHandler`'s overwriting of `useBlock` causes hard-to-debug issues with other mods and is just painfully incompatible.

alcatrazEscapee opened this issue ยท 0 comments

commented

Version: 1.18.2, Chisel + Bits 1.2.114.

This right here:

has caused me a massive headache trying to debug an issue filed with TFC: (TerraFirmaCraft/TerraFirmaCraft#2254). In short: this overwrites, unconditionally any setting of this field by other mods, even when chisel + bits doesn't actually need to. For instance, if RightClickInteractionHandler.rightClickOnBlock returns DEFAULT, then there's no reason to be forcibly setting the behavior, as you're almost by definition, not handling anything here.

Please don't call setUseBlock() unconditionally on every invocation of this event. Other mods may also want to use this field, and more importantly, don't forcibly reset to DEFAULT if another mod has already done something here.