Chisels & Bits - For Fabric

Chisels & Bits - For Fabric

2M Downloads

[1.11.2] Slab like forms not counting as solid for the purposes of placing beds/doors

Rosethorns opened this issue ยท 11 comments

commented

Solid surface chiseled blocks are not counting as solid for the purpose of placing certain objects like beds and doors when they are less than a full block in size.

reproduce:

  1. create a couple of top-slab-like blocks
  2. try to place a bed ontop

Versions:

  • MC Version: 1.11.2
  • C&B Version: 1.3.10
  • Do You have Optifine: no
commented

These blocks are checking for "Full Size Cubes" rather then solid tops, which requires forge patches to change which method they call.

Also for the record, beds probably aren't ever going to change, since that also requires changing spawning mechanics, that is a way more involved change.

commented

Basically if forge patches any of these, it will just work.

No change is necessarily from C&B's point of view, and I unfortunately don't have time to make the PRs myself however.

I do doubt however that the beds will make it in, because of the spawning implications.

commented

So to clarify, until Forge is patched to allow a change in which method is called, solving this issue is a no go?

commented

Doors correctly check for solid tops. It follows that I could place doors on chiseled top slabs.

2017-04-09_00 34 17

Beds do not correctly check for solid tops, they check if the blocks underneath are fully opaque (which is deprecated by Forge). Beds also do not break if you dig under them. So place the bed on a solid block like dirt, then dig the dirt out and place your chiseled blocks underneath.

2017-04-09_00 39 14

The weird bed behavior is a vanilla 'feature'.

commented

The weird bed behavior is weird, but it also breaks the spawn mechanic, since "it wont work" if the bed is not on an opaque block. So it sort of gets downgraded to decoration.

Nice that doors work though.

commented

If I remember correctly, for respawning to work the bed must have a valid spot under the blocks next to it, not under the bed itself. And even without a valid spot, it will still let you sleep - but when you wake up you may fall or suffocate. Without the valid spot, if you die you will respawn at the world spawn.

commented

I have submitted a patch to forge on 1.12, and it has been merged.

Beds won't be changing unless vanilla changes them, I think that's about all that can be done regarding this issue.

commented

@AlgorithmX2 So when we get the Forge update, we'll be able to put doors and flower pots on C&B blocks? That's great! Thank you for fixing that!

commented

is this also why I can't place flower pots on my c&b shelves and side tables?

commented

Yes

commented

Eugh looks like I'll have to finally suck it up and move to 1.12! Nice fix!