ChoiceTheorem's Overhauled Village

ChoiceTheorem's Overhauled Village

30M Downloads

[BUG] Generated pillager outpost is placed over a vanilla one, resulting in floating vanilla outpost remnants

thcrt opened this issue · 2 comments

commented

Describe the bug
It appears that CTOV Pillager Outposts may generate without preventing vanilla outposts from generating. This results in floating blocks and other structure parts from the vanilla outposts still being present. Vanilla outposts should be prevented from generating when a CTOV outpost is generated.

Version info
Minecraft 1.20.1
CTOV 3.4.2
Mods installed
Mods:
  [✔] AdaptiveTooltips-1.3.0-fabric-1.20.2
  [✔] AdditionalAdditions-6.0.1
  [✔] AdvancementPlaques-1.20.1-fabric-1.4.11
  [✔] Armorful-2.0.2+1.20
  [✔] AttributeFix-Fabric-1.20.1-21.0.4
  [✔] BarteringStation-v8.0.0-1.20.1-Fabric
  [✔] BetterAnimationsCollection-v8.0.0-1.20.1-Fabric
  [✔] BetterBeacons-Fabric-1.20.1-2.0.0
  [✔] BetterThirdPerson-Fabric-1.20-1.9.0
  [✔] BetterTotemOfUndying-Fabric-1.20.4-2.0.1
  [✔] BetterTridents-v8.0.1-1.20.1-Fabric
  [✔] Bookshelf-Fabric-1.20.1-20.1.9
  [✔] Bountiful-6.0.3+1.20.1-fabric
  [✔] CerbonsAPI-Fabric-1.20.1-1.1.0
  [✔] Clumps-fabric-1.20.1-12.0.0.3
  [✔] Companion-1.20-fabric-5.1.0
  [✔] CompletionistsIndex-v8.0.0-1.20.1-Fabric
  [✔] Controlling-fabric-1.20.1-12.0.2
  [✔] CosmeticArmor-1.20-1.6.0
  [✔] Couplings-1.9.4+1.20
  [✔] CreativeCore_FABRIC_v2.11.16_mc1.20.1
  [✔] DEUF_Refabricated-MC1.20.1-1.1.0
  [✔] DeathKnell-Fabric-1.20.1-10.0.4
  [✔] Debugify-1.20.1+2.0
  [✔] DungeonsArise-1.20.1-2.1.57-fabric-release
  [✔] EasyAnvils-v8.0.1-1.20.1-Fabric
  [✔] EasyMagic-v8.0.1-1.20.1-Fabric
  [✔] EquipmentCompare-1.20.1-fabric-1.3.8
  [✔] FallingTree-1.20.1-4.3.4
  [✔] FauxCustomEntityData-fabric-1.20.1-6.0.1
  [✔] ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric
  [✔] Highlighter-1.20.1-fabric-1.1.6
  [✔] Iceberg-1.20.1-fabric-1.1.18
  [✔] ImmediatelyFast-Fabric-1.2.10+1.20.4
  [✔] InventoryProfilesNext-fabric-1.20-1.10.9
  [✔] ItemBorders-1.20.1-fabric-1.2.0
  [✔] ItemPhysic_FABRIC_v1.7.0_mc1.20.1
  [✔] Jade-1.20-fabric-11.7.0
  [✔] Kambrik-6.1.1+1.20.1-fabric
  [✔] Kiwi-1.20.1-fabric-11.5.4
  [✔] LeaveMyBarsAlone-v8.0.0-1.20.1-Fabric
  [✔] LevelTextFix-Fabric-1.20.1-7.0.2
  [✔] Log-Begone-Fabric-1.20.1-1.0.8
  [✔] MapTooltip-fabric-1.20-3.0.0
  [✔] MaxHealthFix-Fabric-1.20.1-12.0.2
  [✔] MindfulDarkness-v8.0.3-1.20.1-Fabric
  [✔] MixinConflictHelper-1.2.0
  [✔] MouseTweaks-fabric-mc1.20-2.25
  [✔] NaturesCompass-1.20.1-2.2.3-fabric
  [✔] Neat-1.20-35-FABRIC
  [✔] NetherChested-v8.0.3-1.20.1-Fabric
  [✔] Nullscape_1.20.4_v1.2.4
  [✔] PickUpNotifier-v8.0.0-1.20.1-Fabric
  [✔] Prism-1.20.1-fabric-1.0.5
  [✔] PuzzlesLib-v8.1.16-1.20.1-Fabric
  [✔] Searchables-fabric-1.20.1-1.0.2
  [✔] SelfishVillager-0.2.0+sha.c219fe2
  [✔] SlotCycler-v8.0.1-1.20.1-Fabric
  [✔] SmoothScrollingRefurbished+1.20-1.1.2
  [✔] Soulbound-Fabric-0.6+1.20.1
  [✔] StackDeobfuscatorFabric-1.4.2+bf1fc22
  [✔] SuperBetterGrass-1.5.2+1.20.1
  [✔] Survival-Tooltips-1.0.0+1.20.1
  [✔] Tips-Fabric-1.20.1-12.0.4
  [✔] TradingPost-v8.0.2-1.20.1-Fabric
  [✔] TravelersTitles-1.20-Fabric-4.0.2
  [✔] VisualWorkbench-v8.0.0-1.20.1-Fabric
  [✔] YeetusExperimentus-Fabric-2.3.0-build.4+mc1.20.1
  [✔] YungsApi-1.20-Fabric-4.0.3
  [✔] YungsBetterDesertTemples-1.20-Fabric-3.0.3
  [✔] YungsBetterDungeons-1.20-Fabric-4.0.3
  [✔] YungsBetterEndIsland-1.20-Fabric-2.0.5
  [✔] YungsBetterJungleTemples-1.20-Fabric-2.0.4
  [✔] YungsBetterMineshafts-1.20-Fabric-4.0.4
  [✔] YungsBetterNetherFortresses-1.20-Fabric-2.0.5
  [✔] YungsBetterOceanMonuments-1.20-Fabric-3.0.4
  [✔] YungsBetterStrongholds-1.20-Fabric-4.0.3
  [✔] YungsBetterWitchHuts-1.20-Fabric-3.0.3
  [✔] YungsExtras-1.20-Fabric-4.0.3
  [✔] alternate-current-mc1.20-1.7.0
  [✔] antique-atlas-1.1.4+1.20
  [✔] antique-fwaystones-1.1.0+1.19
  [✔] appleskin-fabric-mc1.20.1-2.5.1
  [✔] architectury-9.1.13-fabric
  [✔] artifacts-fabric-9.2.2
  [✔] autotag-2.0.2+1.20
  [✔] badpackets-fabric-0.4.3
  [✔] balm-fabric-1.20.1-7.2.1
  [✔] bbs-1.20.1-0.1.3-fabric
  [✔] better-clouds-1.3.14+1.20.1
  [✔] better_log4j_config-1.2.0-fabric
  [✔] betterstats-3.8+fabric-1.20.1
  [✔] blame-log-0.4.0-1.18
  [✔] blur-3.1.0
  [✔] bundle-recipe-v1.0.0
  [✔] cloth-config-11.1.118-fabric
  [✔] collective-1.20.1-7.30
  [✔] comforts-fabric-6.3.5+1.20.1
  [✔] compacthelpcommand-1.20.1-2.5
  [✔] ctov-3.4.2
  [✔] deeper-oceans-mc1.20-v1.0.1a
  [✔] diamond-in-the-rough-1.20.1-1.1.1
  [✔] disenchanter-0.1.8+1.20
  [✔] dragonloot-1.1.4
  [✔] dynamic-fps-3.3.3+minecraft-1.20.0
  [✔] eating-animation-1.20+1.9.5
  [✔] emi-1.1.0+1.20.1+fabric
  [✔] emi_enchanting-0.1.0+1.20.1
  [✔] emi_loot-0.6.5+1.20.1
  [✔] emitrades-fabric-1.2.1+mc1.20.1
  [✔] enchantedshulkers-mc1.20.1-v1.2.3
  [✔] enchantmentcompat-1.2.1+1.20
  [✔] enhancedblockentities-0.9+1.20
  [✔] entity_model_features_fabric_1.20.1-1.2.3
  [✔] entity_texture_features_fabric_1.20.1-5.2.3
  [✔] entityculling-fabric-1.6.2-mc1.20.1
  [✔] environmentz-2.0.8
  [✔] expanded_tooltips-1.20.1-1.1.0-fabric
  [✔] experienced_crops-1.20.1-1.1.0-fabric
  [✔] fabric-api-0.91.1+1.20.1
  [✔] fabric-end-remastered-5.2.4
  [✔] fabric-language-kotlin-1.10.17+kotlin.1.9.22
  [✔] fastback-0.15.6+1.20.1-fabric
  [✔] fastpaintings-1.20-1.2.4-fabric
  [✔] ferritecore-6.0.1-fabric
  [✔] fzzy_core-0.4.2+1.20.1
  [✔] gear_core-0.3.7+1.20.1
  [✔] guarding-2.4.0
  [✔] heracles-fabric-1.20.1-1.1.9
  [✔] herdspanic-1.0.7
  [✔] idwtialsimmoedm-0.3.0+1.20
  [✔] indium-1.0.30+mc1.20.4
  [✔] inmis-2.7.2-1.20.1
  [✔] inmisaddon-1.0.4
  [✔] jumpoverfences-fabric-1.20.1-1.3.1
  [✔] justmobheads-1.20.1-7.5
  [✔] justplayerheads-1.20.1-3.3
  [✔] kubejs-fabric-2001.6.4-build.133
  [✔] lambdynamiclights-2.3.2+1.20.1
  [✔] lazydfu-0.1.3
  [✔] letmedespawn-fabric-1.20.x-1.2.0
  [✔] levelz-1.4.13
  [✔] libIPN-fabric-1.20-4.0.1
  [✔] libz-1.0.3
  [✔] lithium-fabric-mc1.20.1-0.11.2
  [✔] lithostitched-fabric-1.20.1-1.1.5
  [✔] lmft-1.0.2+1.20-fabric
  [✔] lunade-fastanim-1.6-1.20
  [✔] memoryleakfix-fabric-1.17+-1.1.5
  [✔] mixintrace-1.1.1+1.17
  [✔] mobs-attempt-parkour-0.5.2-1.20
  [✔] modelfix-1.14-fabric
  [✔] modernfix-fabric-5.13.0+mc1.20.1
  [✔] modmenu-7.2.2
  [✔] monsters-in-the-closet-1.0.3+1.20
  [✔] moonlight-1.20-2.9.10-fabric
  [✔] more_spawners-1.0.0
  [✔] moreculling-1.20.4-0.22.1
  [✔] moremobvariants-fabric+1.20-1.2.2
  [✔] nerb-1.20.1-0.3-FABRIC
  [✔] netherportalfix-fabric-1.20-13.0.1
  [✔] notenoughanimations-fabric-1.7.1-mc1.20.1
  [✔] notenoughcrashes-4.4.7+1.20.1-fabric
  [✔] nvidium-0.2.6-beta
  [✔] owo-lib-0.11.2+1.20
  [✔] passiveshield-1.20.1-3.4
  [✔] player-animation-lib-fabric-1.0.2-rc1+1.20
  [✔] potionring-fabric-1.20-1.0
  [✔] qu-enchantments-1.3.6-1.20
  [✔] quickrightclick-1.20.1-1.4
  [✔] radiantgear-fabric-2.1.0+1.20.1
  [✔] raised-fabric-1.20.1-3.1.1
  [✔] reeses_sodium_options-1.7.2+mc1.20.1-build.101
  [✔] resourcefullib-fabric-1.20.1-2.1.23
  [✔] rhino-fabric-2001.2.2-build.18
  [✔] scorched-1.1.3c
  [✔] seamless-2.2.2-fabric-1.20.1
  [✔] seamless-loading-screen-2.0.3+1.20.1-fabric
  [✔] separatedleaves-2.4.0-fabric-1.20.4
  [✔] shifting-wares-2.1.0+1.20.2
  [✔] sihywtcamd-1.8+1.20.1
  [✔] skeletonhorsespawn-1.20.1-3.8
  [✔] skinlayers3d-fabric-1.6.2-mc1.20.1
  [✔] smoothswapping-0.9.3.1-1.20.2-fabric
  [✔] sodium-extra-0.5.4+mc1.20.1-build.115
  [✔] sodium-fabric-0.5.8+mc1.20.1
  [✔] spark-1.10.53-fabric
  [✔] sparsestructures-2.1.2
  [✔] spelunkery-1.20.1-0.3.5-fabric
  [✔] stendhal-1.4.1-1.20
  [✔] swingthrough-1.0.4+1.19
  [✔] tectonic-mod-1.19.3-v2.2
  [✔] things-0.3.3+1.20
  [✔] threadtweak-fabric-1.20.2-0.1.1
  [✔] tia-1.20-1.1-fabric
  [✔] tntbreaksbedrock-1.20.1-3.2
  [✔] trashslot-fabric-1.20-15.1.0
  [✔] trinkets-3.7.1
  [✔] tru.e-ending-v1.1.0b
  [✔] trulytreasures-1.20-3.0.0
  [✔] unsafe-world-random-access-detector-1.1.0
  [✔] various-starting-loot-4.0
  [✔] villagerarmor-5.0.1
  [✔] wanderingcollector-1.2.1+mc1.20-pre5
  [✔] warrior-rage-1.20.1-fabric-1.0.0
  [✔] whats-that-slot-fabric-1.3.4+1.20.1
  [✔] wits-1.1.0+1.20.1-fabric
  [✔] wraith-waystones-3.3.2+mc1.20.1
  [✔] wso16-fabric-1.2
  [✔] yet-another-config-lib-fabric-3.2.1+1.20
  [✔] your-reputation-0.2.4+jade.1.20
  [✔] zombiehorsespawn-1.20.1-4.8
Log output (abridged)
[14:54:58] [main/WARN]: [MixinConfig#onSelect] Reference map 'ctov-fabric-refmap.json' for ctov.mixins.json could not be read. If this is a development environment you can ignore this message
[14:54:58] [main/WARN]: [MixinConfig#onSelect] Reference map 'ctov-common-refmap.json' for ctov-common.mixins.json could not be read. If this is a development environment you can ignore this message

[14:55:26] [Render thread/INFO] (Minecraft) [ReloadableResourceManagerImpl#reload] Reloading ResourceManager: vanilla, fabric (adaptive-tooltips, additionaladditions, advanced_runtime_resource_pack, advancementplaques, alternate-current, antique-atlas, antique-fwaystones, appleskin, armorful, artifacts, attributefix, autotag, autotag-convention, balm-fabric, barteringstation, better_beacons, better_log4j_config, better_totem_of_undying, betterclouds, betterdeserttemples, betterdungeons, betterfortresses, betterjungletemples, bettermineshafts, betteroceanmonuments, betterstats, betterstrongholds, betterthirdperson, bettertridents, betterwitchhuts, blur, bookshelf, bountiful, caffeineconfig, cardinal-components-base, cardinal-components-entity, cardinal-components-item, cardinal-components-world, cloth-config, clumps, coat, comforts, companion, completionistsindex, conditional-mixin, controlling, cosmetic-armor, creativecore, ctov, dark-matter-base, dark-matter-danger, deathknell, debugify, disenchanter, ditr, dragonloot, dungeons_arise, dynamic_fps, easyanvils, easymagic, eatinganimationid, emi, emi_enchanting, emi_loot, emitrades, enchantedshulkers, enchantmentcompat, endrem, enhancedblockentities, entity_model_features, entity_texture_features, entityculling, environmentz, equipmentcompare, expanded_tooltips, experienced_crops, fabric-api, fabric-api-base, fabric-api-lookup-api-v1, fabric-biome-api-v1, fabric-block-api-v1, fabric-block-view-api-v2, fabric-blockrenderlayer-v1, fabric-client-tags-api-v1, fabric-command-api-v1, fabric-command-api-v2, fabric-commands-v0, fabric-containers-v0, fabric-content-registries-v0, fabric-convention-tags-v1, fabric-crash-report-info-v1, fabric-data-generation-api-v1, fabric-dimensions-v1, fabric-entity-events-v1, fabric-events-interaction-v0, fabric-events-lifecycle-v0, fabric-game-rule-api-v1, fabric-item-api-v1, fabric-item-group-api-v1, fabric-key-binding-api-v1, fabric-keybindings-v0, fabric-language-kotlin, fabric-lifecycle-events-v1, fabric-loot-api-v2, fabric-loot-tables-v1, fabric-message-api-v1, fabric-mining-level-api-v1, fabric-model-loading-api-v1, fabric-models-v0, fabric-networking-api-v1, fabric-networking-v0, fabric-object-builder-api-v1, fabric-particles-v1, fabric-recipe-api-v1, fabric-registry-sync-v0, fabric-renderer-api-v1, fabric-renderer-indigo, fabric-renderer-registries-v1, fabric-rendering-data-attachment-v1, fabric-rendering-fluids-v1, fabric-rendering-v0, fabric-rendering-v1, fabric-resource-conditions-api-v1, fabric-resource-loader-v0, fabric-screen-api-v1, fabric-screen-handler-api-v1, fabric-sound-api-v1, fabric-transfer-api-v1, fabric-transitive-access-wideners-v1, fabricloader, fallingtree, fastback, faster_entity_animations, fastpaintings, faux-custom-entity-data, forgeconfigapiport, fwaystones, fzzy_core, gear_core, guarding, heracles, herdspanic, hermes, highlighter, idwtialsimmoedm, immediatelyfast, indium, inmis, inmisaddon, inventoryprofilesnext, itemphysic, jade, jankson, jumpoverfences, kiwi, kubejs, lambdabettergrass, lambdynlights, lavender, lavender-md, lazydfu, letmedespawn, leveltextfix, levelz, libgui, libipn, libz, lithium, lmft, logbegone, maelstrom_library, maptooltip, midnightlib, mindfuldarkness, mixintrace, mm, mobs_attempt_parkour, modernfix, modmenu, monsters_in_the_closet, moonlight, more_spawners, moreculling, moremobvariants, mr_true_ending, naturescompass, neat, netherchested, netherportalfix, notenoughanimations, notenoughcrashes, nullscape, nvidium, omega-config, owo, porting_lib_attributes, porting_lib_core, porting_lib_gametest, potionring, pride, puzzlesapi, qu-enchantments, raised, reach-entity-attributes, reeses-sodium-options, reputation, satin, scribe, seamless, seamless_loading_screen, searchables, selfish-villager, shifting-wares, sihywtcamd, skinlayers3d, slotcycler, smoothswapping, sodium, sodium-extra, soulbound, spark, sparsestructures, spelunkery, spruceui, stackdeobfuscator, staticdata, stendhal, step-height-entity-attribute, survival-tooltips, swingthrough, tcdcommons, tectonic, things, threadtweak, tia, tipsmod, tradingpost, trashslot, travelerstitles, trinkets, trulytreasures, tweed4_annotated, tweed4_base, tweed4_data, tweed4_data_hjson, tweed4_tailor_coat, tweed4_tailor_lang_json_descriptions, tweed4_tailor_screen, wandering_collector, warriorrage, whats_that_slot, wits, yeetusexperimentus, yet_another_config_lib_v3), seamless:default_seamless, lambdabettergrass:default, spelunkery:unlit_redstone_ores, minecraft:supporteatinganimation, spelunkery:better_vanilla_gems, KubeJS Resource Pack [assets]

[14:55:38] [Worker-ResourceReload-3/ERROR] (Minecraft) [LootDataType#method_51205] Couldn't parse element loot_tables:ctov:chests/village/village_forager

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:desert_village_waystone to village ctov:village/desert_oasis/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/mountain_alpine/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/savanna_na/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/swamp/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/snowy_igloo/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/mushroom/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:red_desert_village_waystone to village ctov:village/mesa_fortified/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:desert_village_waystone to village ctov:village/desert/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/savanna/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:desert_village_waystone to village ctov:village/beach/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/taiga/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:stone_brick_village_waystone to village ctov:village/underground/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:red_desert_village_waystone to village ctov:village/mesa/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:mossy_stone_brick_village_waystone to village ctov:village/jungle/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/mountain/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/halloween/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/christmas/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/plains/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/swamp_fortified/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/plains_fortified/house
[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:village_waystone to village ctov:village/taiga_fortified/house

[14:55:44] [Server thread/INFO] (Fabric-Waystones) [WaystonesWorldgen#registerVillage] Adding waystone fwaystones:mossy_stone_brick_village_waystone to village ctov:village/jungle_tree/house

[15:01:58] [Render thread/INFO] (Minecraft) [ChatHud#logChatMessage] [System] [CHAT] Structure(s) at your location:§r\n - §6minecraft:pillager_outpost§r\n - §6ctov:pillager_outpost_desert

commented

Not something, I can deal with.

commented

This is happening because you moved the CTOV pillager outposts out of data/minecraft/worldgen/structure_set/pillager_outposts.json and into its own structure set at data/ctov/worldgen/structure_set/pillager_outposts.json with same placement settings. The new CTOV pillager outposts structure_set uses the exact same placement salt, spacing, and seperation as vanilla pillager outposts, which causes CTOV pillager outposts to generate on the exact same spot as vanilla outposts.