ChoiceTheorem's Overhauled Village

ChoiceTheorem's Overhauled Village

Mods
37M Downloads

[BUG]

ChocoBooyy opened this issue ยท 2 comments

commented

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a new Minecraft 1.20.1 instance based on Forge 47.3.0
  2. Add ChoiceTheorem's Overhauled Village 3.4.11 and Lithostiched 1.4
  3. Start Minecraft
  4. Create a new world
  5. Check the logs
[17:57:51] [Worker-ResourceReload-6/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:ctov:chests/village/village_forager
com.google.gson.JsonSyntaxException: Missing expand, expected to find a Boolean
	at net.minecraft.util.GsonHelper.m_13912_(GsonHelper.java:181) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading,re:mixin}
	at net.minecraft.world.level.storage.loot.entries.TagEntry$Serializer.m_7267_(TagEntry.java:86) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.entries.TagEntry$Serializer.m_7267_(TagEntry.java:72) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.entries.LootPoolSingletonContainer$Serializer.m_5921_(LootPoolSingletonContainer.java:151) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.entries.LootPoolSingletonContainer$Serializer.m_5921_(LootPoolSingletonContainer.java:129) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.entries.LootPoolEntryContainer$Serializer.m_7561_(LootPoolEntryContainer.java:86) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.entries.LootPoolEntryContainer$Serializer.m_7561_(LootPoolEntryContainer.java:74) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.GsonAdapterFactory$JsonAdapter.deserialize(GsonAdapterFactory.java:102) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:76) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1319) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1290) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:179) ~[gson-2.10.jar%23100!/:?] {}
	at net.minecraft.util.GsonHelper.m_13808_(GsonHelper.java:463) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading,re:mixin}
	at net.minecraft.util.GsonHelper.m_13836_(GsonHelper.java:471) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading,re:mixin}
	at net.minecraft.world.level.storage.loot.LootPool$Serializer.deserialize(LootPool.java:192) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.LootPool$Serializer.deserialize(LootPool.java:189) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:76) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:40) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.internal.bind.ArrayTypeAdapter.read(ArrayTypeAdapter.java:72) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1319) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1290) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.internal.bind.TreeTypeAdapter$GsonContextImpl.deserialize(TreeTypeAdapter.java:179) ~[gson-2.10.jar%23100!/:?] {}
	at net.minecraft.util.GsonHelper.m_13808_(GsonHelper.java:463) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading,re:mixin}
	at net.minecraft.util.GsonHelper.m_13845_(GsonHelper.java:481) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading,re:mixin}
	at net.minecraft.world.level.storage.loot.LootTable$Serializer.deserialize(LootTable.java:294) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.LootTable$Serializer.deserialize(LootTable.java:291) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:classloading}
	at com.google.gson.internal.bind.TreeTypeAdapter.read(TreeTypeAdapter.java:76) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1214) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1319) ~[gson-2.10.jar%23100!/:?] {}
	at com.google.gson.Gson.fromJson(Gson.java:1261) ~[gson-2.10.jar%23100!/:?] {}
	at net.minecraftforge.common.ForgeHooks.loadLootTable(ForgeHooks.java:871) ~[forge-1.20.1-47.3.0-universal.jar%23551!/:?] {re:classloading}
	at net.minecraftforge.common.ForgeHooks.lambda$getLootTableDeserializer$3(ForgeHooks.java:848) ~[forge-1.20.1-47.3.0-universal.jar%23551!/:?] {re:classloading}
	at net.minecraft.world.level.storage.loot.LootDataType.deserialize(LootDataType.java:45) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:mixin,re:classloading}
	at net.minecraft.world.level.storage.loot.LootDataManager.lambda$scheduleElementParse$4(LootDataManager.java:56) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:mixin,re:classloading,pl:mixin:APP:placebo.mixins.json:LootTablesMixin,pl:mixin:APP:railways.mixins.json:MixinLootDataManager,pl:mixin:APP:architectury.mixins.json:MixinLootDataManager,pl:mixin:APP:kubejs-common.mixins.json:LootTablesMixin,pl:mixin:A}
	at java.util.HashMap.forEach(HashMap.java:1421) ~[?:?] {re:mixin}
	at net.minecraft.world.level.storage.loot.LootDataManager.m_278660_(LootDataManager.java:55) ~[client-1.20.1-20230612.114412-srg.jar%23546!/:?] {re:mixin,re:classloading,pl:mixin:APP:placebo.mixins.json:LootTablesMixin,pl:mixin:APP:railways.mixins.json:MixinLootDataManager,pl:mixin:APP:architectury.mixins.json:MixinLootDataManager,pl:mixin:APP:kubejs-common.mixins.json:LootTablesMixin,pl:mixin:A}
	at java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) ~[?:?] {}
	at java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) ~[?:?] {}
	at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) ~[?:?] {}
	at java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) ~[?:?] {re:mixin,re:computing_frames}
	at java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) ~[?:?] {re:mixin,re:computing_frames}
	at java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165) ~[?:?] {re:mixin}

Expected behaviour
That the error does not appear in the logs.

Minecraft Version
1.20.1

CTOV Version
3.4.11

Do you install Lithostitched?(1.20+)
Yes.

Log
https://mclo.gs/2A2hSbI

Additional context
I'm trying to clean up the errors in my logs when i saw this one.

commented

The suggestion is accepted and will be patched next update!

commented

Here's how i fixed it with a datapack:

{
	"pools": [
		{
			"rolls": 5,
			"entries": [
				{
					"type": "minecraft:tag",
					"weight": 1,
					"name": "byg:mushrooms_for_foragers_table",
					"expand": true
				},
				{
					"type": "minecraft:tag",
					"weight": 1,
					"name": "byg:all/saplings",
					"expand": true
				}
			],
			"functions": [
				{
					"function": "minecraft:set_count",
					"count": {
						"min": 1,
						"max": 10
					}
				}
			]
		}
	]
}