ChoiceTheorem's Overhauled Village

ChoiceTheorem's Overhauled Village

13M Downloads

Crash in Mod Options

bcrotty opened this issue ยท 4 comments

commented

What is wrong?
image
When I click on the mod in the main menu mods list or from mod options in-game, Minecraft crashes to the the desktop.
What version of minecraft do you use?
1.19.2 (All the Mods 8)
What version of CTOV do you use?
3.1.8
The log or screen capture of the bug
https://pastebin.com/Ac268CYm

commented

I have the same issue.
I think line #30 of mods.toml is at fault here. The line above it says that the logo should be in the root of the mod jar. Not assets/

commented

I think I managed to fix it on my fork of the repository (tested with IntelliJ IDEA on Java 17 and a minimal build environment; no compat). I plan to open a PR (one of my first few PRs ever, so bear with me) shortly to discuss the changes.

commented

I'll deal with it next release!

commented

Sounds good. Honestly the PR may not happen as I ended up fighting with github's new(-ish, at least to me as rarely as I push) authentication workflow. I can try to get it in if you want, though the two commits I made are pretty simple either way (one copies the logo and updates the reference, the other deletes the old one). Tested the fix against Java 17 with IntelliJ IDEA just to be sure.