
Border not showing up right in Dynmap, Pl3xmap,...
Closed this issue ยท 3 comments
Server Version: PaperMC 1.21.6 48
ChunkyBorder Version: ChunkyBorder 1.2.23
When i set an border as a circle, the world maps will not display it correctly. The WorldBorder text is inside the border, and i believe its supposed to be outside of the border. For example mine map: https://mapa.emparia.sk. When border is set like circle, it will show World Border text inside the border, but outside it wont. look at pictures


From our discussion in Discord earlier:
looks like leaflet's circle doesnt take into consideration the center being possibly empty https://github.com/Leaflet/Leaflet/blob/c905af655723d1b6440b2fc74d45075b5950122e/src/layer/vector/CircleMarker.js#L102-L104
however, in the ellipse class i added i made sure to account for this https://github.com/granny/Pl3xMap/blob/d1614bc0b3d667628ef7e01cc0fe06ac3ee51993/webmap/src/lib/L.ellipse.js#L244-L251
so the fix is to change your worldborder from a circle to an ellipse. it'll still look like a circle if you use the same radius values for both x and y
unfortunately, this isn't something you can do (unless you feel like forking ChunkyBorder and compiling the fix in yourself)
https://github.com/pop4959/ChunkyBorder/blob/master/common/src/main/java/org/popcraft/chunkyborder/integration/Pl3xMapIntegration.java#L43
you'll have to talk to pop to get him to change from a circle to an ellipse right there in the code.
looks like pl3xmap, squaremap, and dynmap integrations in ChunkyBorder have this issue
Thanks Billy, @svkaviator737 shared in Discord. Looks easy, just wasn't aware there was a workaround for this limitation. I'll take a look tonight (or as soon as I have chance) unless someone decides to PR before then.
Fixed in 37690f6. However @BillyGalbreath when testing I did not see the same issues with Dynmap. Looks to be working fine there.