Cinderscapes

Cinderscapes

1M Downloads

On 1.16.2 Branch Decorators are broken

Vaerian opened this issue ยท 10 comments

commented

Exactly what it says on the tin, some of the decorators are broken so most of the features don't generate properly.

commented

Maybe @shartte can take a look at this?

commented
commented

I believe only the custom ones

commented

Can you give an example that doesn't generate?

I don't see anything particularly wrong with it, and some custom decorator based features seem to generate:
image
(I thought these mushrooms are based on one of the custom decorators)

commented

the current problem is in the spikes biome, the spikes arent generating but we're thinking it may be an issue with the shapes code so we're investigating that since we also confirmed that the decorators seems to be functioning

commented

Yeah all of that works, but basically the features that aren't working are the blackstone shales (in their namesake biome), they kind of spawn but not in the same quantities, and the quartz spikes in the quartz whatever the hell biome.

commented

Scoder says it's a problem with the generation shapes itself not the decorators, which it could be, but the shapes lib is MC independent and hasn't changed so I dunno if that's affecting it. It could be that the whitelists got messed up and stuff somewhere, but I can take a look at it if you don't find anything.

commented

Hm, this is hard to debug without knowing how it should look ;-)

So, just placing a diamond-block column unconditionally in the ShaleFeature looks like this:

image

commented
commented

I looked at CeilingShardFeature and it seems the shapes are always empty.

I dont know if that's the same issue as the shales (might not be).

Overall I don't think I can help with this one as the decorators seem to be generally working at least.