CIT Type Enchantment
SHsuperCM opened this issue · 17 comments
I'd suggest Misa's Realistic Texture Pack, I makes heavy use of MCPatcher/Optifine features and had custom enchantment glints in 1.7.
Link to the 1.7 version: https://www.mediafire.com/file/so06m43621fp23k/Misa%252B.zip/file
Specifications are too unclear to implement as is.
Need to find a working pack example and/or reverse engineer mcpatcher's implementation because the docs for this are shit.
Try xali's enchanted books if you need an example pack, it's pretty comprehensive as I believe it covers every enchantment at every level.
Try xali's enchanted books if you need an example pack, it's pretty comprehensive as I believe it covers every enchantment at every level.
Yeah but that pack is not using type=enchantment, it's just replacing enchanted book visuals using type=item and I'm looking for packs that used to replace the glint.png texture.
what about
https://www.curseforge.com/minecraft/texture-packs/enchanted-tools
https://www.curseforge.com/minecraft/texture-packs/enchanted-weapons
https://www.curseforge.com/minecraft/texture-packs/enchanted-armors
That's not what SHsuperCM is looking for, it's a separate thing I guess. I don't know of any packs that replace the enchant glint using CIT
Yep, it seems to me like there arent any packs for this because it's been a broken feature for so long in optifine..
Gonna need something like.. mcpatcher level of old texturepacks and just play with it in an old mc version.. that is, if I cant figure out how it was implemented back then from mcpatcher's code which is luckily available.
v0.8.0 is out with partial support for type=enchantment!
On top of the default configuration of the type in optifine's cit_single.properties there is also blur which defaults to true, this blurs the texture before it's applied(which happens with the vanilla glint)
Right now the type is missing blend, duration and the global properties are missing method and fade
The only thing missing right now is the global mixing method for how the intensities are linked to the enchantment condition if present.
(and the docs for everything)
Just noticed that MCPatcher handled it less like actual enchantment glints, more like an overlay. Maybe add an
animationoption or something similar.(I hope I ported the pack correctly)
I'm going to need the pack before and after your port to compare. A lot of mcpatcher's handling of this had to be written from scratch to work with modern mc so there's definitely some differences.
I reduced the properties files and changed the numerical enchantmentIDs to the new ones
Original (also mentioned above):
https://www.mediafire.com/file/so06m43621fp23k/Misa%252B.zip/file
My port:
Enchantment Tests.zip
I also just noticed it may have something to do with the blur option, I think MCPatcher also disables the slow scrolling animation when it is false.
Edit: I used Animatica for custom animated textures.
Just noticed that MCPatcher handled it less like actual enchantment glints, more like an overlay. Maybe add an animation option or something similar.
(I hope I ported the pack correctly)
I reduced the properties files and changed the numerical
enchantmentIDsto the new onesOriginal (also mentioned above): https://www.mediafire.com/file/so06m43621fp23k/Misa%252B.zip/file
My port: Enchantment Tests.zip
I also just noticed it may have something to do with the
bluroption, I think MCPatcher also disables the slow scrolling animation when it is false.Edit: I used Animatica for custom animated textures.
Ok so I got it working like in mcpatcher.. sorta....
First to stop the texture from scrolling, I noticed that the default scroll speed in CIT Resewn is 1.0 and apparently in mcpatcher the default was 0.0 so that needs fixing. You should probably set it manually with speed=0 as well to have it explicitly defined.
Then also it seems that mcpatcher offset the texture by half a Y unit so it matches with the item.
There isn't a way to do that with CITR yet so I tried just doing it in code quickly to check and it seems to work fine now.
I'll open an issue for those to get a permanent solution going and probably target v1.1.0.