CIT Resewn

CIT Resewn

14M Downloads

1.19: Loading packs is very long

MeeniMc opened this issue ยท 5 comments

commented

It takes a long time to load packs with the new 1.19 version.

I suspect the following change is the reason, as it instantiates a larger object that we do not really use for anything

resourceManager.getResource(pathIdentifier).isPresent() see changeset 0935c49#r75861019

commented

Was worried about it as well when I read through the PRs. Only way I could think of to bypass it is fairly invasive though so I'll have to take a deeper look at what can be done.

commented

this is a vanilla issue and was fixed on 1.19.1

The issue will be looked into again when 1.19.1 comes out to confirm this. If it's just an issue with 1.19.0 I'll mark it as wontfix.

The getResource usage still bothers me but if it's not as urgent as I thought, it will just be fixed eventually.

commented

this is a vanilla issue and was fixed on 1.19.1

commented

I tested today with 1.19.1pre3 (citresewn still works with the snapshots btw) and it appears the issue is fixed when using this version.

commented

(citresewn still works with the snapshots btw)

Thanks for letting me know.

I tested today with 1.19.1pre3 and it appears the issue is fixed when using this version.

Glad to hear, I don't think there is a reason to fix this for 1.19.0 then.