Citadel

Citadel

83M Downloads

Biome source mixin conflict with Biolith (potentially Terrablender as well)

Su5eD opened this issue · 3 comments

commented

An issue has been reported to me on Sinytra/Connector#396 regarding Alex's Caves biomes not generating when Biolith is installed. I've tracked this down to a mixin conflict targetting the MultiNoiseBiomeSource class.

The isssue

  • Biolith is deliberately configured to always inject last to ensure compatibility with terrablender.
  • Terrablender's mixin uses default priority, which means "lottery" decides who comes out on top.
  • Citadel's mixin also uses default priority, but only cancels conditionally.

Terrablender always cancels, just like Biolith, so it's enough that this race condition ends in terrablender injecting last, and alex's caves will never be able to run its replacements.
I don't know how the backing SortedSet decides the order of equal elements, it could be the hashcode, name, anything.
But right now, terrablender goes first, and so Citadel has a change to run its replacements where needed. Biolith, on the other hand, will always break as explained above.

The solution

Since citadel only cancels where neded, it's enough that the mixin priority be lowered below biolith's one, and it should be guaranteed to work.

commented

What would you recommend to set the priority to?

commented

fixed in 2.4.6

commented

I can confirm that Terrablender seems to be causing this issue for me consistently. Enabling Terrablender, even without mods that add in new biomes, prevents caves from Alex's Caves from generating.