Citadel

Citadel

Mods
83M Downloads

[1.20.1] Mixin injecting SynchedEntityData into entities not owned by Citadel is dangerous

TelepathicGrunt opened this issue ยท 0 comments

commented

Entity Data Accessors should only be ever set by the creator of the entity. Never added to by other mods.

The reason for this is because Entity Data Accessors are order dependent so if multiple mods tries to add these entity data accessors to mobs and on client, they run in a different order than the server did (because mod load order is not guaranteed), the client will get forcibly disconnected from server when the entity spawns.

Instead, this mixin part needs to be removed and migrated properly to a Forge Capability because capabilities were designed specifically for this use case of attaching data to arbitrary entities. It is safer for mods as the vanilla system is designed specifically only for vanilla and unsafe for mods. Then you would use your own packet to send the data to client when needed.

Citadel/src/main/java/com/github/alexthe666/citadel/mixin/LivingEntityMixin.java

Lines 20 to 31 in 06a3c35

public abstract class LivingEntityMixin extends Entity implements ICitadelDataEntity {
private static final EntityDataAccessor<CompoundTag> CITADEL_DATA = SynchedEntityData.defineId(LivingEntity.class, EntityDataSerializers.COMPOUND_TAG);
protected LivingEntityMixin(EntityType<? extends Entity> entityType, Level world) {
super(entityType, world);
}
@Inject(at = @At("TAIL"), remap = CitadelConstants.REMAPREFS, method = "Lnet/minecraft/world/entity/LivingEntity;defineSynchedData()V")
private void citadel_registerData(CallbackInfo ci) {
entityData.define(CITADEL_DATA, new CompoundTag());
}

This is especially a problem in large modpacks where many mods are doing this. Example is TNPLimitless 7 where there's many mods injecting SynchedEntityData onto entities and are getting out of order due to mod load order. Which is causes a lot of reports of people getting disconnected from server due to:
image