Clumps

Clumps

206M Downloads

StackOverflowError (recursion on ExperienceOrb.java:222)

Tander opened this issue ยท 10 comments

commented

Sometimes (not always), when a player enchanted gear picks up an experience orb, he causes Exception and getting kicked from server (Internal Server Error). After it he can't rejoin until all orbs will be gone. Reloading server is also helps. We tried to remove items with enchantments from erroring players, but got inconsistent results so far.

Here what we get in console:

[11:50:50] [Server thread/WARN]: Failed to handle packet for /<ip hidden>
net.minecraft.ReportedException: Ticking player
	at net.minecraft.server.level.ServerPlayer.m_9240_(ServerPlayer.java:502) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.network.ServerGamePacketListenerImpl.m_9933_(ServerGamePacketListenerImpl.java:207) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.network.Connection.m_129483_(Connection.java:245) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.network.ServerConnectionListener.m_9721_(ServerConnectionListener.java:142) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:916) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.dedicated.DedicatedServer.m_5703_(DedicatedServer.java:326) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at java.lang.Thread.run(Unknown Source) [?:?]
Caused by: java.lang.StackOverflowError
	at java.util.HashMap.putVal(Unknown Source) ~[?:?]
	at java.util.HashMap.putMapEntries(Unknown Source) ~[?:?]
	at java.util.HashMap.<init>(Unknown Source) ~[?:?]
	at com.google.common.collect.Maps.newHashMap(Maps.java:258) ~[guava-31.0.1-jre.jar%2321!/:?]
	at net.minecraft.nbt.CompoundTag.m_6426_(CompoundTag.java:426) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.nbt.CompoundTag.m_6426_(CompoundTag.java:22) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at com.google.common.collect.Iterators$6.transform(Iterators.java:826) ~[guava-31.0.1-jre.jar%2321!/:?]
	at com.google.common.collect.TransformedIterator.next(TransformedIterator.java:52) ~[guava-31.0.1-jre.jar%2321!/:?]
	at com.google.common.collect.Iterators.addAll(Iterators.java:367) ~[guava-31.0.1-jre.jar%2321!/:?]
	at com.google.common.collect.Lists.newArrayList(Lists.java:147) ~[guava-31.0.1-jre.jar%2321!/:?]
	at com.google.common.collect.Lists.newArrayList(Lists.java:133) ~[guava-31.0.1-jre.jar%2321!/:?]
	at net.minecraft.nbt.ListTag.m_6426_(ListTag.java:314) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.nbt.ListTag.m_6426_(ListTag.java:12) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at com.google.common.collect.Maps$9.transformEntry(Maps.java:2053) ~[guava-31.0.1-jre.jar%2321!/:?]
	at com.google.common.collect.Maps$12.getValue(Maps.java:2101) ~[guava-31.0.1-jre.jar%2321!/:?]
	at java.util.HashMap.putMapEntries(Unknown Source) ~[?:?]
	at java.util.HashMap.<init>(Unknown Source) ~[?:?]
	at com.google.common.collect.Maps.newHashMap(Maps.java:258) ~[guava-31.0.1-jre.jar%2321!/:?]
	at net.minecraft.nbt.CompoundTag.m_6426_(CompoundTag.java:426) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.item.ItemStack.m_41777_(ItemStack.java:407) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.item.ItemStack.handler$zel000$forbiddenArcanus_isDamageableItem(ItemStack.java:1600) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.item.ItemStack.m_41763_(ItemStack.java:284) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.item.ItemStack.m_41768_(ItemStack.java:292) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.item.enchantment.EnchantmentHelper.m_44839_(EnchantmentHelper.java:290) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.entity.ExperienceOrb.m_147092_(ExperienceOrb.java:222) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.entity.ExperienceOrb.m_147092_(ExperienceOrb.java:228) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.entity.ExperienceOrb.m_147092_(ExperienceOrb.java:228) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	at net.minecraft.world.entity.ExperienceOrb.m_147092_(ExperienceOrb.java:228) ~[server-1.18.2-20220404.173914-srg.jar%23142!/:?]
	(... e.t.c)

Could you look at your side if it can be caused by Clumps in any way?
Any help with troubleshooting will be appreciated

Modpack is https://www.curseforge.com/minecraft/modpacks/elittle-dragon-expedition

commented

Try removing clumps and seeing if that resolves the issue, but from the log it seems to potentially be related to Forbidden-Arcanus

commented

Tried, but no xp orbs were found (maybe chunk was unloaded faster than I could apply command). We temporarely disabled Clumps, I let you know with results.

commented

No problem since i removed Clumps... But I'll keep monitoring and let you know with results

commented

Well, looks like replacing your mod with equivalent one (adaptive performance tweaks) helped, no more Internal Server Errors.
So most likely it was incompatibility with another mod, but I have no idea with which one. I guess you can close this issue now

commented

My guess is forbidden arcanus just based on the stack trace, but I'll close it and if anyone else has issues they can make a new issue

commented

@jaredlll08 Issues is gone since we switched to another mod for compacting xp orbs, so it was most likely the problem on your side. Here is more info from F&A author: stal111/Forbidden-Arcanus#271 (comment)

commented

@Tander I think you're a bit confused there.

So for starters, moving to another mod could fix it but that mod may not have true vanilla experience mechanics in terms of mending and experience gained, which you can see from the multiple closed issues on this repo, is a very important thing for people to have.

The comment you linked to was a comment I wrote, telling them what I believe the issue is in their code.

Clumps is an insanely huge mod that is heavily used in modpacks, if there was a general issue with a stack overflow that was not related to Forbidden Arcanus (so just clumps on it's own), we would be swamped with reports about it (like this issue for example: #105, where there was an actual issue with clumps, and multiple people reported it within 4 hours of the code being live).

commented

I am having a very similar issue but on a different enviroment and modpack. Should i recreate the issue post?

commented

please do, and give all the information, mod list, mc version, clumps version etc

commented

This was an issue with clumps, more info here #107