My keybind box link works offline but not on my server
Closed this issue · 6 comments
I assume you're carrying the Box Link item in your inventory or curio/trinket slot, yes? need some more details here, cause you might have the item requirement disabled on singleplayer, but not on the server, which would be a simple problem to resolve.
Though it could also be another thing, some "safety" i tried to set up and didn't remove, if the former doesn't help too much, send over your server's log, preferably through a paste site.
This is where it is worn, and in my offline world it works perfectly. It doesn't affect gameplay too much, I can still open PC with right click when holding, I'm just curious why the shortcut doesn't work when I play on the server. (Sorry if I write a bit confusing, I use google translate)
it appears to be the "safety" feature activating, so uh, that's not ideal, and the reason it's happening also seems difficult to tell.
the simplest way i can explain it is the way it's written in the code, which is that when sending the RequestOpenPCPacket, the Client puts what should be the player's UUID (from Minecraft.getInstance().getUser().getProfileId()) into the packet, when the server receives the packet, it checks that the UUID sent in the packet matches that of the player.
Why did i do this? cause i didn't know beforehand that the network handling events on NeoForge and Fabric would let me access the player that sent the packet, but they do. idk it's kinda difficult to explain why exactly it was there in the first place, but it seemed like it didn't hurt to keep it, so i didn't remove it at any point. clearly that's come back to bite me in some fashion.
i've seen another instance of a report of a problem like this in a random support thread in Cobblemon's Discord, but i'm not sure if there's something in common between your version of the issue, and the other person's.
Oh, something i should ask from you, what did "offline" refer to in your response and post title? I'd assume it might be a Singleplayer World, but as "Offline Mode" is a thing that exists for Servers, i can't be sure without input from you.
should be fixed by this commit, whose changes are in the 1.0.4 version.