CCBlockStateLoader keeps dangling ModelLoader reference
asiekierka opened this issue ยท 6 comments
This prevents FoamFix, especially an upcoming release, from doing major RAM usage optimizations.
Do you need that dangling ModelLoader reference? Forge disposes of it after model baking is complete, as IModels can still be dynamically loaded through the ModelLoaderRegistry.
Nope its not needed after baking, VanillaLoader
and VariantLoader
also store a reference in case you weren't aware :D
@covers1624 ...oh.
...okay, that's fair, nevermind. Couldn't spot it at first. I relied on that reference once, so I'm surprised I didn't remember. Sorry.
Ill clean it up my end, but i'm fairly sure its safe to nuke the instances inside VariantLoader
and VanillaLoader
, unless anything lazy loads models that is.
@covers1624 Some mods do lazy-load models, probably. FoamFix's optimization will make everything lazy-load models, as 90% of them aren't used.
I'm not going to nuke the instances, I'm just going to, um, FoamFix them a bit more. Yeah. I forgot I had the dangling ref.