CodeChicken Lib 1.8.+

Hi, you have a resource leak because an IResource isn't closed here:

CodeChickenLib/src/main/java/codechicken/lib/render/OBJParser.java

Line 64 in c68dcf0

    
           return parseModels(Minecraft.getMinecraft().getResourceManager().getResource(res).getInputStream(), vertexMode, coordSystem);

Just close your IResouce in a finally block or with try-with-resources, and you will be fine.
These leaks can be observed by forcing debug to be enabled for minecraft loggers using the log4j xml

Hey, was just wondering if there was any progress made with this. Many new versions have been uploaded to curseforge since this post, but I couldn't find a changelog.

I'm currently using Ancient Warfare 2, and wondering how much this could affect me.

Completely forgot about this issue, 1663747. Currently getting back-end stuff ready for the next release, doing some infrastructure changes.

Share to