CodeChicken Lib 1.8.+

CodeChicken Lib 1.8.+

Mods
141M Downloads

Suggestion: Change OpenGL version detection to use reflection

Janrupf opened this issue · 3 comments

commented

Looking at the issues #172 and #166. This can easily be resolved by changing the detection here

CodeChickenLib/src/main/java/codechicken/lib/render/OpenGLUtils.java

Lines 27 to 32 in 4d48a21

openGL20 = caps.OpenGL20;
openGL32 = caps.OpenGL32;
openGL40 = caps.OpenGL40;
openGL43 = caps.OpenGL43;
openGL44 = caps.OpenGL44;
openGL45 = caps.OpenGL45;
to use reflection and catching exceptions. This might even happen on the Vanilla launcher and its not a that big pain to simply fix this. You can't expect everyone to use the latest version of LWJGL because some new version are bugged on some OS.

commented

A bit of context:

  • This is coming from people using outdated versions of MultiMC (it did default to 2.9.1 for all versions)
  • In the current version, the user can choose any of the Mojang-provided LWJGL versions of LWJGL. That means you can get LWJGL 2.9.1 in Minecraft 1.12.2, or LWJGL 2.9.4 in old beta versions. It is up to the user. The default is whatever was in the upstream Mojang version json though.
  • This works well in Vanilla, and up to now, worked flawlessly with pretty much every other mod.

Feel free to close this. The users should not be running ancient cracked versions of MultiMC.

commented

That has been my stance up until now, don't be using ancient versions of things, mojang ships 2.9.4 so things should use that. But mitigation has been added: 68c1667

  • 👍2
commented

Partially true:

        {
            "name": "org.lwjgl.lwjgl:lwjgl:2.9.2-nightly-20140822",
            "rules": [
                {
                    "action": "allow",
                    "os": {
                        "name": "osx"
                    }
                }
            ],...
        }```

Looks like this nightly is few days later than the commit which is required for `caps.OpenGL45`