CodeChicken Lib 1.8.+

CodeChicken Lib 1.8.+

141M Downloads

IITemRenderer Incompatabilities

jredfox opened this issue ยท 7 comments

commented

when two mods replace the IITemRenderer one will take over the other will simply not work
jredfox/evilnotchlib#11

As you can see my mod fired after yours and the ender storage tanks are invisible.

Solution: we need to not replace one another renderers. I don't know if we both need to go asm or just one or the other. We could write a universal class which will have hashmaps between item and IITemRender as an array I don't know we could figure something out.

Maybe we could just simply use both the same code. I think you will like the setup it was written by elix_x
https://github.com/jredfox/evilnotchlib/tree/master/src/main/java/com/elix_x/itemrender

commented

No, you are not overriding the renderer properly, I'm careful and delegate any render calls to the renderer im overriding, you simply need to do the same, its not rocket science, this is entirely on your end.

commented

Also, Forge now has hooks, Item.setTESIR or something like that, use that hook, IItemRenderer stuff in CCL will be rewritten in 1.13.

commented

or there is a simpler way for us to add compat.

Have your RenderItem object call super() on everything if your item isn't mapped and doesn't need to override could you do that for me please? thanks I will make the edits the the RenderItem.class on my side

If you don't want to call super call your render item object you store in your wrapper class render item if you have no overrides. Currently the issue is fixed on my side but, not yours. I did a method replace test and now yours is the one overriding mine

commented

You still don't understand and I'm sick of your shit, pleas just read my replays, extend RenderItem, do what ccl's does, look in my client proxy for how I initialize it and it will work, you don't need asm, parent override classes are not rocket science.

commented

no I didn't understand what you were doing that's why I asked. Don't worry I figured it out. Yeah I guess I don't need the asm but, it's already do.

I might have understood sooner if you simple said create a wrapper RenderItem and use that. You confused me and said you could grab and use delegates or something there were none.

commented

Literelly anyone would have followed my explanation. Parent overrides are a standard in the community..

commented

thanks anyways for pointing out it was my logic that was the error