"Ore exists" recipe condition passes even if there are no matching items
phantamanta44 opened this issue ยท 1 comments
In particular, if a mod registers an ore name without registering any items under that name, the condition will still pass despite this ore ingredient being unsatisfiable.
I propose replacing the check for ore name existence with a check for the existence matching items:
return () -> !OreDictionary.getOres(ore, false).isEmpty();
This fixes issues such as phantamanta44/tinkers-evolution#8, where Avaritia uses an ore-exists recipe condition to register fluxed electrum singularities despite there being no items matching the blockElectrumFlux
key.