CodeChickenCore

CodeChickenCore

Mods
31M Downloads

MCOutputStreamWrapper not compatible with PacketCustom

Schmoller opened this issue ยท 1 comments

commented

Despite both implementing MCDataOutput, they differ in how they write strings:

  • PacketCustom uses varInt(2) for length (through ByteBufUtils)
  • MCOutputStreamWrapper uses short for length

Both of these are used together in ForgeMultipart (readDesc and writeDesc on TMultiPart) thus causing strings to be unreadable

commented

Nicely picked.
Fixed as of f9fea33 CCL 1.1.1.78 and FMP 1.1.0.277