CodeChickenCore

CodeChickenCore

31M Downloads

[ASM] Instruction comparison does not apply remapping.

Laikulo opened this issue ยท 1 comments

commented

When a method or field instruction (e.g. INVOKEVIRTUAL) is compared (via InsnComparator's methodInsnEqual and fieldInsnEqual), mappings are not taken into effect.

What should happen:
net.minecraft.SomeClass.someMethod (IILnet/minecraft/someClass;)V is treated the same as net.minecraft.SomeClass.func_12345_x.(IILnet/minecraft/someClass;)V

This often causes crashes with NEI's use of the modular transformer when in a deobfuscated environment.

commented

I'm an idiot.. Disregard