Coins JE

Coins JE

Mods
133k Downloads

[Cheeky Request] please back-port for 1.14

Royal-Jelly opened this issue · 6 comments

commented

I'm almost certain requests like this are frowned at, but i have to ask since it seems like 1.14.4 is where all the mods will be staying for "lts" support from the forge development team

commented

Sorry for missing this. Life has been crazy lately. Thanks for the PR, it's now been merged and is on CF.

  • ❤️2
commented

Took a look at it, and its depends on function in Bookshelf, that's wasn't avaible in 1.14.4-4.4.74,
so that package need some back-porting first. So put an Issue in that repo, and may try to backport it next week-

commented

@Darkhax According to your comment in Bookshelf, it's sound like you suggesting removing the loot-table-injection in a backport of Coins.

@Royal-Jelly if that is an acceptable lose, ie the coins can't be found in village chests, then I think I can make an 1.14.4 version, and make a pull request for it.

Coins/src/main/java/net/darkhax/coins/Coins.java

Lines 37 to 54 in eade286

this.registry.injectTable(LootTables.CHESTS_PILLAGER_OUTPOST);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_ARMORER);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_BUTCHER);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_CARTOGRAPHER);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_DESERT_HOUSE);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_FISHER);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_FLETCHER);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_MASON);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_PLAINS_HOUSE);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_SAVANNA_HOUSE);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_SHEPHERD);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_SHEPHERD);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_SNOWY_HOUSE);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_TAIGA_HOUSE);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_TANNERY);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_TEMPLE);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_TOOLSMITH);
this.registry.injectTable(LootTables.CHESTS_VILLAGE_VILLAGE_WEAPONSMITH);

commented

@Darkhax Don't know how to make a PR to a new branch, didn't wanted to make a PR for the 1.15.2 branch.

Here is a downgraded version:
https://github.com/puggan/Coins/tree/1.14.4/no-chest-loot

Tested all recipts, and the creative-mode-tab. Works fine in 1.14.4, but the loot-injectin is out-commented.

commented

Thanks puggan for the reply, I will move discussion to the appropriate place

commented

thank you very much for this puggan, and sorry about the late reply life came up