Conditional Recipes aren't being properly ignored
MuteTiefling opened this issue · 4 comments
Cold Sweat version 2.4-b04a
These recipes attempt to load despite Thirst not being installed:
KubeJS is catching them and throwing an error as a result.
KubeJS Server Logs: https://mclo.gs/1u7Ybly
Latest Logs: https://mclo.gs/XlUI4GT
I haven't used the latest beta release of Cold Sweat 2.4, but I can confirm this is still an issue in the previous release version of Cold Sweat
What's silly though, is that I get these errors caught by KubeJS even with Thirst installed
Something is just not parsing those recipes with the waterskins right
I definitely wasn't getting them when I had Thirst Was Taken in. But I've decided to remove that and started getting this instead.
Disabling manually for now, but a fix in the mod would be appreciated. Code for anyone else that would like it:
ServerEvents.generateData('after_mods', (event) => {
const neverLoad = {
'neoforge:conditions': [{ type: 'neoforge:never' }]
};
const recipes = [
{ id: 'waterskin_acceptable_campfire' },
{ id: 'waterskin_acceptable_furnace' },
{ id: 'waterskin_purified_campfire' },
{ id: 'waterskin_purified_furnace' },
{ id: 'waterskin_slightly_dirty_campfire' }
];
recipes.forEach((recipe) => {
event.json(`cold_sweat:recipe/compat/thirst/${recipe.id}`, neverLoad);
});
});This issue has been fixed in beta versions of Cold Sweat. It's difficult to retroactively apply fixes to older versions, so the fix won't be coming to 2.3.12, unfortunately. I'll be closing this issue because you seem to have found a solution and nothing more can be done here. Thanks for the report, though.