Minecarts containing any item cause a server crash when destroyed naturally

Question

Minecarts containing any item cause a server crash when destroyed naturally

notebook-bfb opened this issue 2 years ago · 0 comments

notebook-bfb commented 2 years ago

When a Minecart with X (Chest, Furnace, Insulation, etc) is broken, the game immediately crashes. A player breaking the minecart seems to be exempt from this.

Steps to Reproduce

place a minecart w/ chest
place a cactus
push the minecart into the cactus

Crash Report

---- Minecraft Crash Report ----
// Shall we play a game?

Time: 10/15/22, 1:55 AM
Description: Colliding entity with block

org.spongepowered.asm.mixin.injection.callback.CancellationException: The call m_6469_ is not cancellable.
	at org.spongepowered.asm.mixin.injection.callback.CallbackInfo.cancel(CallbackInfo.java:101) ~[mixin-0.8.5.jar%2348!/:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {re:mixin}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.handler$zza000$hurt(AbstractMinecart.java:988) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_6469_(AbstractMinecart.java:224) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.level.block.CactusBlock.m_7892_(CactusBlock.java:98) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.m_60682_(BlockBehaviour.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,re:mixin}
	at net.minecraft.world.entity.Entity.m_20101_(Entity.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_146872_(Entity.java:696) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_6478_(Entity.java:668) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.moveMinecartOnRail(AbstractMinecart.java:867) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_6401_(AbstractMinecart.java:498) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_8119_(AbstractMinecart.java:314) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.server.level.ServerLevel.m_8647_(ServerLevel.java:652) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.Level.m_46653_(Level.java:487) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:319) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading}
	at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:299) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:833) ~[?:?] {}


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at org.spongepowered.asm.mixin.injection.callback.CallbackInfo.cancel(CallbackInfo.java:101) ~[mixin-0.8.5.jar%2348!/:0.8.5+Jenkins-b310.git-155314e6e91465dad727e621a569906a410cd6f4] {re:mixin}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.handler$zza000$hurt(AbstractMinecart.java:988) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_6469_(AbstractMinecart.java:224) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.level.block.CactusBlock.m_7892_(CactusBlock.java:98) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.block.state.BlockBehaviour$BlockStateBase.m_60682_(BlockBehaviour.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,re:mixin}
	at net.minecraft.world.entity.Entity.m_20101_(Entity.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_146872_(Entity.java:696) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_6478_(Entity.java:668) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.moveMinecartOnRail(AbstractMinecart.java:867) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_6401_(AbstractMinecart.java:498) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_8119_(AbstractMinecart.java:314) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.server.level.ServerLevel.m_8647_(ServerLevel.java:652) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.Level.m_46653_(Level.java:487) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:319) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading}
	at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:299) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
-- Block being collided with --
Details:
	Block: Block{minecraft:cactus}[age=0]
	Block location: World: (-35,76,-143), Section: (at 13,12,1 in -3,4,-9; chunk contains blocks -48,-64,-144 to -33,319,-129), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
Stacktrace:
	at net.minecraft.world.entity.Entity.m_20101_(Entity.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_146872_(Entity.java:696) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_6478_(Entity.java:668) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.moveMinecartOnRail(AbstractMinecart.java:867) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_6401_(AbstractMinecart.java:498) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_8119_(AbstractMinecart.java:314) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.server.level.ServerLevel.m_8647_(ServerLevel.java:652) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.Level.m_46653_(Level.java:487) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:319) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading}
	at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:299) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:833) ~[?:?] {}


-- Entity being checked for collision --
Details:
	Entity Type: minecraft:chest_minecart (net.minecraft.world.entity.vehicle.MinecartChest)
	Entity ID: 506
	Entity Name: Minecart with Chest
	Entity's Exact location: -34.50, 76.00, -141.57
	Entity's Block location: World: (-35,76,-142), Section: (at 13,12,2 in -3,4,-9; chunk contains blocks -48,-64,-144 to -33,319,-129), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
	Entity's Momentum: -0.00, -0.04, 0.00
	Entity's Passengers: []
	Entity's Vehicle: null
Stacktrace:
	at net.minecraft.world.entity.Entity.m_146872_(Entity.java:696) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.Entity.m_6478_(Entity.java:668) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.moveMinecartOnRail(AbstractMinecart.java:867) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_6401_(AbstractMinecart.java:498) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.world.entity.vehicle.AbstractMinecart.m_8119_(AbstractMinecart.java:314) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:mixin,re:classloading,pl:mixin:APP:cold_sweat.mixin.json:MixinMinecart,pl:mixin:A}
	at net.minecraft.server.level.ServerLevel.m_8647_(ServerLevel.java:652) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.Level.m_46653_(Level.java:487) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:319) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading}
	at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:299) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:833) ~[?:?] {}


-- Entity being ticked --
Details:
	Entity Type: minecraft:chest_minecart (net.minecraft.world.entity.vehicle.MinecartChest)
	Entity ID: 506
	Entity Name: Minecart with Chest
	Entity's Exact location: -34.50, 76.00, -141.57
	Entity's Block location: World: (-35,76,-142), Section: (at 13,12,2 in -3,4,-9; chunk contains blocks -48,-64,-144 to -33,319,-129), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
	Entity's Momentum: -0.00, -0.04, 0.00
	Entity's Passengers: []
	Entity's Vehicle: null
Stacktrace:
	at net.minecraft.world.level.Level.m_46653_(Level.java:487) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B}
	at net.minecraft.server.level.ServerLevel.m_184063_(ServerLevel.java:319) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.world.level.entity.EntityTickList.m_156910_(EntityTickList.java:54) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading}
	at net.minecraft.server.level.ServerLevel.m_8793_(ServerLevel.java:299) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:833) ~[?:?] {}


-- Affected level --
Details:
	All players: 1 total; [ServerPlayer['mNotebook'/66, l='ServerLevel[New World]', x=-35.02, y=76.00, z=-141.02]]
	Chunk stats: 2809
	Level dimension: minecraft:overworld
	Level spawn location: World: (-32,76,-144), Section: (at 0,12,0 in -2,4,-9; chunk contains blocks -32,-64,-144 to -17,319,-129), Region: (-1,-1; contains chunks -32,-32 to -1,-1, blocks -512,-64,-512 to -1,319,-1)
	Level time: 403 game time, 403 day time
	Level name: New World
	Level game mode: Game mode: creative (ID 1). Hardcore: false. Cheats: true
	Level weather: Rain time: 147929 (now: false), thunder time: 81216 (now: false)
	Known server brands: forge
	Level was modded: true
	Level storage version: 0x04ABD - Anvil
Stacktrace:
	at net.minecraft.server.MinecraftServer.m_5703_(MinecraftServer.java:902) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_5705_(MinecraftServer.java:842) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.client.server.IntegratedServer.m_5705_(IntegratedServer.java:84) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:runtimedistcleaner:A}
	at net.minecraft.server.MinecraftServer.m_130011_(MinecraftServer.java:685) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at net.minecraft.server.MinecraftServer.m_177918_(MinecraftServer.java:261) ~[client-1.18.2-20220404.173914-srg.jar%2354!/:?] {re:classloading,pl:accesstransformer:B}
	at java.lang.Thread.run(Thread.java:833) ~[?:?] {}

Speculation

I suspect that this commit is responsible for the crash: 4165ff4
Cancelling the callback as done here doesn't seem to be as safe as was assumed.

Additionally, it seems that this issue has arisen before and been patched (#83),
so I'm assuming that the patch was undone by mistake.

Share to

Steps to Reproduce

Crash Report

Speculation