Collector's Album [Fabric | Forge]

Collector's Album [Fabric | Forge]

32.8k Downloads

If you hit esc after opening a pack, you lose the cards (also some feedback)

katubug opened this issue · 4 comments

commented

Hi! My friends and I have been playing with your mod on my server, and we've got a few suggestions, plus what I suspect is unintended behaviour.

Firstly, the bug is that if you hold to open a pack, but you don't click the cards to turn them over - the pack is still consumed, but you don't get anything. You just lose those cards.

We also have some feedback:

  1. It would be nice to have an easier way of putting them into the book. Shift+click doesn't work, so that in particular would be nice. Or just "dropping" them onto the book from the inventory screen? I know that would be complicated once all slots were filled, though.
  2. Opening cards is a bit slow. That's why I tried hitting esc, to see if it would automatically give me the cards. Don't get me wrong: I LOVE clicking them and hearing the little fanfares. It's incredibly satisfying and I still do that with the bigger card packs. But for lower-rank packs, I still want to open but more quickly.
  3. Having them sort in either numeric and/or rank order when using the auto-sort function from other mods. This is the big one! We've either got to sort them manually before putting them into the book, or we have to hover over them a billion times to see which goes onto the current page. It's a little frustrating, and takes away from the satisfaction of the mod.

Thanks for the great mod, and for listening! Have a great day!

commented

Hi,
the bug you reported was actually wanted feature by @Tomano123CZ. We could possibly add config option for this though.

  1. I could propably implement the shift click functionality in a way that it would be able to swap even already taken slots.
  2. You will be able to simply just Esc in the pack once the config option is added
  3. The sorting may be interesting. What mods are you using for this? I could take a look if they provide some API for custom sorters, because otherwise I guess its sorted by name and that might be slighly complicated to implement currently.

Thanks for the feedback

commented
commented

Regarding the sorting - I have implemented support for their sort system, so it should now sort the cards in the order you wanted. Config option will be also available for the partially opened card packages (you don't need to change anything, your wanted behaviour is set as default). And lastly, you will be able to move/swap cards using shift-click (the swap works only for cards which have higher rarity)

commented