With Collectors Reap installed all fish stop spawning, including from vanilla and other mods.

Using the latest versions of CR and FD on forge 47.2.0

I just installed the same version of forge and can not replicate the issue. Make sure you test on a minimal instance.

Seems to have been cause by my personal datapack paired with this mod, my bad. I'll go ahead and close this