incompatibility with sodium (even with indium)
triphora opened this issue · 8 comments
log - https://paste.ee/p/KpSoI
same setup w/o Colored Lights doesn't crash
Just to update the state of this issue- I have started looking into it, and it does look like it will need to be quite an involved fix. Ideally though fixing this will imply resolving compatibility with other mods that target the same rendering paths. 🙂 The main issue is that other mods are replacing/patching rendering logic for things such as entities, or in the case of Sodium, chunk rendering entirely. For Sodium, we'll need to custom-handle that case specifically so that we can work with their shaders and chunk rendering pipeline.
I hope that this issue can be solved soon, when it does I'll definitely try to use the mod. Until then, I need to use mods like Sodium for performance, so I'll have to wait.
Just in case that no one still add this comment.. on 1.18.1, this still have incompatibility with Sodium, even in latest public build.(idk what about dev builds). and sorry sodium is mor important then some fancy colored lights.
Just to update the state of this issue- I have started looking into it, and it does look like it will need to be quite an involved fix. Ideally though fixing this will imply resolving compatibility with other mods that target the same rendering paths. 🙂 The main issue is that other mods are replacing/patching rendering logic for things such as entities, or in the case of Sodium, chunk rendering entirely. For Sodium, we'll need to custom-handle that case specifically so that we can work with their shaders and chunk rendering pipeline.
@Gegy hi, why you don't use indium? you can use fabric rendering api alongside sodium with indium.
https://github.com/comp500/Indium
Indium is an addon for the rendering optimisation mod Sodium, providing support for the Fabric Rendering API. The Fabric Rendering API is required for many mods that use advanced rendering effects, and is currently not supported by Sodium directly. Indium is based upon the reference implementation Indigo, which is part of Fabric API with source available here. (licensed Apache 2.0)
This error seems to rather be an incompatibility with Sodium than Xaero's minimap, but will need to confirm. Thanks for the report!
Ah. Well, using even latest Sodium and Indium CaffeineMC/sodium@145d664 and comp500/Indium@820073e, it still crashes: https://paste.ee/p/cSpBN
Without Colored Lights, it does not crash.