Colormatic

If I understand correctly the following mixin injection assumes no mod will call the getColor method before the property objects are initialized, and it may be the cause of this crash that was reported to me: zabi94/ExtraAlchemy#81

colormatic/src/main/java/io/github/kvverti/colormatic/mixin/potion/StatusEffectMixin.java

Lines 35 to 42 in 7f770e0

    
           @Inject(method = "getColor", at = @At("HEAD"), cancellable = true) 
        
           private void onColor(CallbackInfoReturnable<Integer> info) { 
        
               StatusEffect self = (StatusEffect)(Object)this; 
        
               int color = Colormatic.COLOR_PROPS.getProperties().getPotion(self); 
        
               if(color != 0) { 
        
                   info.setReturnValue(color); 
        
               } 
        
           }

All the details are included by the user in that report

This is the stack trace: https://pastebin.com/raw/WMqvtL5m
This is where I call the method, nothing is null on my side: https://github.com/zabi94/ExtraAlchemy/blob/5e64eecc6c5a0f361a5869027708cfc8e3e406f4/src/main/java/zabi/minecraft/extraalchemy/statuseffect/ModEffectRegistry.java#L69

bad000 - guess it was bad lol. Looks like you fixed it on your end, but I can look into gating the access behind a check or making sure the properties are initialized. Note that if you cache the colors before resource reload, they may be incorrect regardless.

😂 Jokes aside, I'm kinda curious about where the bad000 name comes from. At first I thought it might be the obfuscated class name for StatusEffect, but it's not

bad000 is the name mixin prepends to the callback for name mangling purposes.

Curious name choice then

	@Inject(method = "getColor", at = @At("HEAD"), cancellable = true)
	private void onColor(CallbackInfoReturnable<Integer> info) {
	StatusEffect self = (StatusEffect)(Object)this;
	int color = Colormatic.COLOR_PROPS.getProperties().getPotion(self);
	if(color != 0) {
	info.setReturnValue(color);
	}
	}

Share to