Columns

Mods
542k Downloads

Outline shapes for columns with ends are not cached

haykam821 opened this issue ยท 0 comments

commented

Currently, VoxelShapes.union is called to create an outline shape for columns with either their up or down properties set to true. These shapes should be stored in a field instead.

Columns/src/main/java/io/github/haykam821/columns/block/ColumnBlock.java

Lines 38 to 44 in 1d89318

if (state.get(UP) && state.get(DOWN)) {
return VoxelShapes.union(UP_SHAPE, CENTER_SHAPE, DOWN_SHAPE);
} else if (state.get(UP)) {
return VoxelShapes.union(UP_SHAPE, CENTER_SHAPE);
} else if (state.get(DOWN)) {
return VoxelShapes.union(CENTER_SHAPE, DOWN_SHAPE);
} else {