Tooltip conflict
Techokami opened this issue ยท 9 comments
Versions (Be specific, do not write "latest"):
- Colytra: 1.14.4-2.0.0.1
- Caelus (for 1.13+): 1.14.4-1.0.1.1
- Forge: 1.14.4-forge-28.1.90
Observed Behavior: When combining an Elytra with a chestplate, the tooltip for the resulting chestplate does not reflect that there is an Elytra attached. Possibly a conflict with Quark, which also changes tooltips.
Expected Behavior: Expected to see content that matched screenshots on Curseforge page.
Steps to Reproduce:
- Use Colytra with Quark
- Craft together a chestplate and an Elytra
- Notice that the chestplate tooltip does not indicate an Elytra present, however it is.
A suggestion that can go along with this: how about being able to render the Elytra as well as the chestplate? It looks really weird to fly around without the Elytra, and it was in fact what I expected the combination to look like from the start. That would make combined chestplates look more obvious, and more awesome.
A suggestion that can go along with this: how about being able to render the Elytra as well as the chestplate?
That's strange, this is already how it is. Are you not seeing the elytra being rendered on your character? Can you try and replicate this with only Colytra and Caelus installed?
I'm facing something similar - in that when you place the chest piece and the elytra in the crafting table - the piece in the output does not show an elytra attached in the tooltip. I can click and accept the piece - however the elytra just disappears and i lose it.
i will test with out quark tomorrow when i get up to see if there's something to that.
using forge 28.1.90
quark r2.0-199
colytra-FORGE-1.14.4-2.0.0.1 - set to PERFECT in the config
caelus-FORGE-1.14.1-1.0.1.1
Well, I can take back the "render with armor" bit, I didn't know that you first had to fly with it before it renders...
Still strange, because it should render regardless. Like a normal elytra, but with a chestplate. It sounds like something might be interfering with the rendering somehow, or possibly some sort of client-server desync if this is in multiplayer.
I did some quick testing and I can't reproduce these issues, everything seems to work fine with Quark installed. Screenshots below of the observed behavior.
This was tested in single player only. Are you seeing this issue in multiplayer, single player, or both?
Also, this was tested with default Quark configs. Are you seeing this issue with default or non-default Quark configs? If so, can you include a copy of your Quark config file?
I just tested it in singleplayer and it all works perfectly. However, I mainly play in multiplayer, which is where I am having these issues. Probably should have checked/clarified that first, but iirc singleplayer and multiplayer got merged YEARS ago, so I dunno how there could be a difference.
I can replicate this without Quark, so it's likely solely a Colytra issue. It seems like a client/server desync issue. It's strange though, I've gotten verification before that it works on servers. Even stranger, from your report it seems like you can still achieve flight. However, I can't craft a proper colytra at all on my test server. I'm not sure if some Forge behavior has changed or if there are other factors at play here.
After looking into possible workarounds, the most straightforward solution might be to regress the fusion method back to anvils instead of crafting. But I'll have to do some more testing to look for alternative solutions.
I think I was able to solve this issue without any visible changes to users, at least from what I can tell from my testing. However, since there were a lot of changes that had to be made to the code, just be aware that I've marked version 2.1.0 as a beta for the moment. Although backwards-compatibility seems to work fine in testing, I can't guarantee that updating won't have a small possibility of breaking existing elytra attachments.