CompactStorage

CompactStorage

11M Downloads

Villagers cant use Barrel for POI

xanthian opened this issue ยท 8 comments

commented

As above :)

commented

It looks like this is something hard coded into Minecraft, the Poi types has it hard coded as Blocks.Barrel, for Fabric I can perhaps do a Mixin to add more but it feels like the type of thing that could break intercompatibility with other mods. Let me look into it and I'll get back to you :)

PoiTypes.java
      register(p_218083_, FISHERMAN, getBlockStates(Blocks.BARREL), 1, 1);
commented

For forge this is registerable, needs to be looked at but should be fixed in a commit today

commented

It is doable.
BetterNether has just added the facility.
Friends and Foes has it for Beehives.

I had it working on my Grindstones and Barrels in 1.18 but can no longer get it working in 1.19
Hidden reason for raising the issue, wondered how you may do it ๐Ÿ˜‹

commented

Interesting, so doesn't even need mixin now. ๐Ÿคฏ

commented

It is doable. BetterNether has just added the facility. Friends and Foes has it for Beehives.

I had it working on my Grindstones and Barrels in 1.18 but can no longer get it working in 1.19 Hidden reason for raising the issue, wondered how you may do it ๐Ÿ˜‹

Interesting! I'll take a look more into it, I started a new job this week so time has been tight!

commented

Here is how I've got it working https://github.com/tabithastrong/compact-storage/blob/fabric/src/main/java/com/tabithastrong/compactstorage/CompactStorage.java#L126 seems to work okay in my testing so will see how it goes with players

commented

Interesting, so doesn't even need mixin now. ๐Ÿคฏ

I've used an access widener as I don't see the need for a Mixin, I could be wrong so just hoping no new bugs come out of it! The 1.19 version was bugged so is being re-released now

commented

Unfortunately impossible in Forge 1.19 because the PoiType is a record, this should also not work on Fabric but for some reason it seems happy so I'm just going to hope it keeps working!